Thanks for the votes y'all! I'm closing this KIP, as equivalent
functionality has now been merged as part of KIP-382.
Ryanne
On Sun, Oct 6, 2019, 7:55 AM Eno Thereska wrote:
> +1
>
> (Non binding)
>
> Thanks
> Eno
>
> > On 4 Oct 2019, at 15:09, Harsha Chintalapani wrote:
> >
> > +1 (binding).
+1
(Non binding)
Thanks
Eno
> On 4 Oct 2019, at 15:09, Harsha Chintalapani wrote:
>
> +1 (binding).
>
> Thanks,
> Harsha
>
>
>> On Fri, Oct 04, 2019 at 6:53 AM, Manikumar
>> wrote:
>>
>> Hi All,
>>
>> Please vote here for the formal approval of this KIP.
>> https://github.com/apache/kaf
+1 (binding).
Thanks,
Harsha
On Fri, Oct 04, 2019 at 6:53 AM, Manikumar
wrote:
> Hi All,
>
> Please vote here for the formal approval of this KIP.
> https://github.com/apache/kafka/pull/6295#discussion_r328867657
>
> Thanks,
>
>
> On Wed, Oct 2, 2019 at 5:50 AM Ryanne Dolan wrote:
>
> Hey y'a
Hi All,
Please vote here for the formal approval of this KIP.
https://github.com/apache/kafka/pull/6295#discussion_r328867657
Thanks,
On Wed, Oct 2, 2019 at 5:50 AM Ryanne Dolan wrote:
> Hey y'all, resurrecting an old KIP for the benefit of KIP-382, which
> depends on an additional parameter
Hey y'all, resurrecting an old KIP for the benefit of KIP-382, which
depends on an additional parameter in SourceTask.commitRecord(). I've
updated KIP-416 according to consensus reached in PR-6295. Let's finish the
vote so we can formally approve this minor KIP, please!
Ryanne
On Mon, Jan 21, 201
Andrew, I agree it's a better commitRecord, but with the slightly different
semantics you mentioned. I suppose we could document that well enough that
reusing the same name would be fine.
I'll resend the discussion email. Maybe it got lost somehow.
Ryanne
On Mon, Jan 21, 2019, 4:37 AM Andrew Sch
Hi,
I'm not quite sure about the etiquette here but I wonder whether the KIP could
be improved. I think I missed the DISCUSS thread.
I think that really your recordLogged(SourceRecord, RecordMetadata) method is
actually a better version of commitRecord() and perhaps it ought to be an
overload.
Hey y'all, please vote for KIP-416 by replying +1 to this thread.
Right now, there is no way for a SourceConnector/Task to know:
- whether a record was successfully sent to Kafka, vs filtered out or
skipped.
- the downstream offsets and metadata of sent records
KIP-416 proposes adding a recordLo
