Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-15 Thread Konstantine Karantasis
Thank you all for the votes and your comments! KIP-415 has been accepted with +4 binding votes (Guozhang, Jason, Randall, Ewen) and +4 non-binding votes (Ryanne, Rhys, Robert, Satish). Best, Konstantine On Thu, Mar 14, 2019 at 10:24 PM Satish Duggana wrote: > Nice work Konstantine! > +1 (non-

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-14 Thread Satish Duggana
Nice work Konstantine! +1 (non-binding) On Fri, Mar 15, 2019 at 7:48 AM Ewen Cheslack-Postava wrote: > +1 (binding) > > -Ewen > > On Wed, Mar 13, 2019 at 2:04 PM Randall Hauch wrote: > > > Excellent work, Konstantine! > > > > +1 (binding) > > > > On Mon, Mar 11, 2019 at 8:05 PM Konstantine Kara

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-14 Thread Ewen Cheslack-Postava
+1 (binding) -Ewen On Wed, Mar 13, 2019 at 2:04 PM Randall Hauch wrote: > Excellent work, Konstantine! > > +1 (binding) > > On Mon, Mar 11, 2019 at 8:05 PM Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Thanks Jason! > > That makes perfect sense. The change is reflected in th

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-13 Thread Randall Hauch
Excellent work, Konstantine! +1 (binding) On Mon, Mar 11, 2019 at 8:05 PM Konstantine Karantasis < konstant...@confluent.io> wrote: > Thanks Jason! > That makes perfect sense. The change is reflected in the KIP now. > "compatible" will be the default mode for "connect.protocol" > > Cheers, > Kon

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-11 Thread Konstantine Karantasis
Thanks Jason! That makes perfect sense. The change is reflected in the KIP now. "compatible" will be the default mode for "connect.protocol" Cheers, Konstantine On Mon, Mar 11, 2019 at 4:31 PM Jason Gustafson wrote: > +1 Thanks for all the work on this. My only minor comment is that > `connect

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-11 Thread Jason Gustafson
+1 Thanks for all the work on this. My only minor comment is that `connect.protocol` probably should be `compatible` by default. The cost is low and it will save upgrade confusion. Best, Jason On Fri, Mar 8, 2019 at 10:37 AM Robert Yokota wrote: > Thanks for the great KIP Konstantine! > > +1 (n

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-08 Thread Robert Yokota
Thanks for the great KIP Konstantine! +1 (non-binding) Robert On Thu, Mar 7, 2019 at 2:56 PM Guozhang Wang wrote: > Thanks Konstantine, I've read the updated section on > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-415%3A+Incremental+Cooperative+Rebalancing+in+Kafka+Connect > and i

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-07 Thread Guozhang Wang
Thanks Konstantine, I've read the updated section on https://cwiki.apache.org/confluence/display/KAFKA/KIP-415%3A+Incremental+Cooperative+Rebalancing+in+Kafka+Connect and it lgtm. I'm +1 on the KIP. Guozhang On Thu, Mar 7, 2019 at 2:35 PM Konstantine Karantasis < konstant...@confluent.io> wrot

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-07 Thread Konstantine Karantasis
Thanks Guozhang. This is a valid observation regarding the current status of the PR. I updated the KIP to explicitly call out how the downgrade process should work in the section Compatibility, Deprecation, and Migration. Additionally, I reduced the configuration modes for the connect.protocol to

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-07 Thread Guozhang Wang
Hi Konstantine, Thanks for the updated KIP and the PR as well (which is huge :) I briefly looked through it as well as the KIP, and I have one minor comment to add (otherwise I'm binding +1 on it as well) about the backward compatibility. I'll use one example to illustrate the issue: 1) Suppose y

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-06 Thread McCaig, Rhys
+1 (non-binding) > On Mar 6, 2019, at 3:40 PM, Ryanne Dolan wrote: > > +1 (non-binding) > > Thanks! > Ryanne > > On Wed, Mar 6, 2019, 4:28 PM Konstantine Karantasis < > konstant...@confluent.io> wrote: > >> I'd like to open the vote on KIP-415: Incremental Cooperative Rebalancing >> in Kafka

Re: [VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-06 Thread Ryanne Dolan
+1 (non-binding) Thanks! Ryanne On Wed, Mar 6, 2019, 4:28 PM Konstantine Karantasis < konstant...@confluent.io> wrote: > I'd like to open the vote on KIP-415: Incremental Cooperative Rebalancing > in Kafka Connect > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-415%3A+Incremental+Coo

[VOTE] KIP-415: Incremental Cooperative Rebalancing in Kafka Connect

2019-03-06 Thread Konstantine Karantasis
I'd like to open the vote on KIP-415: Incremental Cooperative Rebalancing in Kafka Connect https://cwiki.apache.org/confluence/display/KAFKA/KIP-415%3A+Incremental+Cooperative+Rebalancing+in+Kafka+Connect a proposal that will allow Kafka Connect to scale significantly the number of connectors and