Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-13 Thread Stanislav Kozlovski
Hey everybody, I've finished with the implementation, here is the PR: https://github.com/apache/kafka/pull/5908 On Mon, Nov 12, 2018 at 6:58 PM Stanislav Kozlovski wrote: > Thank you, everybody, for the votes and discussion. The KIP has passed > with 3 binding votes (Harsha, Jun, Dong) and 1 no

Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-12 Thread Stanislav Kozlovski
Thank you, everybody, for the votes and discussion. The KIP has passed with 3 binding votes (Harsha, Jun, Dong) and 1 non-binding vote (Kevin) @jun, I added a note on the KIP stating that this isn't related to the Yammer metrics Best, Stanislav On Thu, Nov 8, 2018 at 10:54 PM Dong Lin wrote: >

Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-08 Thread Dong Lin
Thanks for the KIP Stanislav. +1 (binding) On Thu, Nov 8, 2018 at 2:40 PM Jun Rao wrote: > Hi, Stanislav, > > Thanks for the KIP. +1. I guess this only covers the Kafka metrics (not the > Yammer metrics). It would be useful to make this clear. > > Jun > > On Tue, Nov 6, 2018 at 1:00 AM, Stanisla

Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-08 Thread Jun Rao
Hi, Stanislav, Thanks for the KIP. +1. I guess this only covers the Kafka metrics (not the Yammer metrics). It would be useful to make this clear. Jun On Tue, Nov 6, 2018 at 1:00 AM, Stanislav Kozlovski wrote: > Hey everybody, > > I'm starting a vote thread on KIP-386: Standardize on Min/Avg/M

Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-06 Thread Harsha Chintalapani
+1 (binding) -Harsha On Nov 6, 2018, 8:04 AM -0800, Kevin Lu , wrote: > +1 (non-binding) > > Regards, > Kevin > > On Tue, Nov 6, 2018 at 1:01 AM Stanislav Kozlovski > wrote: > > > Hey everybody, > > > > I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max metrics' > > default values

Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-06 Thread Kevin Lu
+1 (non-binding) Regards, Kevin On Tue, Nov 6, 2018 at 1:01 AM Stanislav Kozlovski wrote: > Hey everybody, > > I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max metrics' > default values > > > In short,

[VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values

2018-11-06 Thread Stanislav Kozlovski
Hey everybody, I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max metrics' default values In short, after the discussion thread