Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-14 Thread Srinivas Reddy
Greetings, Code changes has been completed and pushed against to this PR. https://github.com/apache/kafka/pull/5910 Thank you. - Srinivas - Typed on tiny keys. pls ignore typos.{mobile app}

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-12 Thread Srinivas Reddy
Thank you all for votes. Here is the summary of all votes. Binding votes: Colin McCabe Harsha Chintalapani Becket Qin Non binding votes: Viktor Somogyi-Vass Daniele Ascione Mickael Maison Vahid Hashemian I am concluding this voting thread and mark this KIP as accepted. Thanks -- Sriniv

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-12 Thread Vahid Hashemian
+1 (non-binding) Thanks for the KIP. --Vahid On Mon, Nov 12, 2018, 04:06 Mickael Maison wrote: > +1 (non-binding) > Thanks for the KIP! > On Mon, Nov 12, 2018 at 5:16 AM Becket Qin wrote: > > > > Thanks for the KIP. +1 (binding). > > > > On Mon, Nov 12, 2018 at 9:59 AM Harsha Chintalapani > w

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-12 Thread Mickael Maison
+1 (non-binding) Thanks for the KIP! On Mon, Nov 12, 2018 at 5:16 AM Becket Qin wrote: > > Thanks for the KIP. +1 (binding). > > On Mon, Nov 12, 2018 at 9:59 AM Harsha Chintalapani wrote: > > > +1 (binding) > > > > -Harsha > > On Nov 11, 2018, 3:49 PM -0800, Daniele Ascione , > > wrote: > > > +1

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-11 Thread Becket Qin
Thanks for the KIP. +1 (binding). On Mon, Nov 12, 2018 at 9:59 AM Harsha Chintalapani wrote: > +1 (binding) > > -Harsha > On Nov 11, 2018, 3:49 PM -0800, Daniele Ascione , > wrote: > > +1 (non-binding) > > > > Il ven 9 nov 2018, 02:09 Colin McCabe ha scritto: > > > > > +1 (binding) > > > > > >

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-11 Thread Harsha Chintalapani
+1 (binding) -Harsha On Nov 11, 2018, 3:49 PM -0800, Daniele Ascione , wrote: > +1 (non-binding) > > Il ven 9 nov 2018, 02:09 Colin McCabe ha scritto: > > > +1 (binding) > > > > > > > > On Wed, Oct 31, 2018, at 05:42, Srinivas Reddy wrote: > > > Hi All, > > > > > > I would like to call for a vote

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-11 Thread Daniele Ascione
+1 (non-binding) Il ven 9 nov 2018, 02:09 Colin McCabe ha scritto: > +1 (binding) > > > > On Wed, Oct 31, 2018, at 05:42, Srinivas Reddy wrote: > > Hi All, > > > > I would like to call for a vote on KIP-374: > > https://cwiki.apache.org/confluence/x/FgSQBQ > > > > Summary: > > Currently, the '--

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-08 Thread Colin McCabe
+1 (binding) On Wed, Oct 31, 2018, at 05:42, Srinivas Reddy wrote: > Hi All, > > I would like to call for a vote on KIP-374: > https://cwiki.apache.org/confluence/x/FgSQBQ > > Summary: > Currently, the '--help' option is recognized by some Kafka commands > but not all. To provide a consistent us

Re: [VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-11-07 Thread Viktor Somogyi-Vass
+1 (non-binding) Thanks for this KIP. Viktor On Wed, Oct 31, 2018 at 2:43 PM Srinivas Reddy wrote: > Hi All, > > I would like to call for a vote on KIP-374: > https://cwiki.apache.org/confluence/x/FgSQBQ > > Summary: > Currently, the '--help' option is recognized by some Kafka commands > but n

[VOTE] KIP-374: Add '--help' option to all available Kafka CLI commands

2018-10-31 Thread Srinivas Reddy
Hi All, I would like to call for a vote on KIP-374: https://cwiki.apache.org/confluence/x/FgSQBQ Summary: Currently, the '--help' option is recognized by some Kafka commands but not all. To provide a consistent user experience, it would be nice to add a '--help' option to all Kafka commands. I'd