Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-27 Thread Dana Powers
Great questions. But I wonder if we're expanding the scope of this KIP too much? The questions you've raised relate to java client development, and broker testing. Issues #2 and #3 are not related to this KIP at all: how does the server test and validate api protocol changes and compatibility? Tha

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-23 Thread Gwen Shapira
We (Jay + me) had some extra information we wanted to see in the KIP before we are comfortable voting: * Where does the Java client fits in. Hopefully we can use this KIP to standardize behavior and guarantees between Java and non-Java clients, so when we reason about the Java clients, which most

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-23 Thread Dana Powers
speaking of pending KIPs, what's the status on this one? On Fri, Mar 18, 2016 at 9:47 PM, Ashish Singh wrote: > Hey Jay, > > Answers inline. > > On Fri, Mar 18, 2016 at 10:45 AM, Jay Kreps wrote: > > Hey Ashish, > > > > Couple quick things: > > > > 1. You list as a rejected alternative "making

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-19 Thread Jay Kreps
Hey Ashish, Couple quick things: 1. You list as a rejected alternative "making the documentation the source of truth for the protocol", but I think what you actually describe in that section is global versioning, which of those two things are we voting to reject? I think this is a philosophical p

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-19 Thread Magnus Edenhill
+1 (nonbinding) 2016-03-18 0:09 GMT+01:00 Ashish Singh : > As the KIP has been modified since we started this vote, the vote is > restarted from now. > > The updated KIP is available at > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-35+-+Retrieving+protocol+version > . > > On Mon, Mar

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-19 Thread Grant Henke
+1 (non-binding) On Fri, Mar 18, 2016 at 2:41 AM, Magnus Edenhill wrote: > +1 (nonbinding) > > 2016-03-18 0:09 GMT+01:00 Ashish Singh : > > > As the KIP has been modified since we started this vote, the vote is > > restarted from now. > > > > The updated KIP is available at > > > > > https://cwi

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-19 Thread Ashish Singh
As the KIP has been modified since we started this vote, the vote is restarted from now. The updated KIP is available at https://cwiki.apache.org/confluence/display/KAFKA/KIP-35+-+Retrieving+protocol+version . On Mon, Mar 14, 2016 at 3:54 PM, Ashish Singh wrote: > Hey Guys, > > I would like to

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-18 Thread Dana Powers
+1 On Thu, Mar 17, 2016 at 4:09 PM, Ashish Singh wrote: > As the KIP has been modified since we started this vote, the vote is > restarted from now. > > The updated KIP is available at > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-35+-+Retrieving+protocol+version > . > > On Mon, Mar

Re: [VOTE] KIP-35: Retrieving protocol version

2016-03-18 Thread Ashish Singh
Hey Jay, Answers inline. On Fri, Mar 18, 2016 at 10:45 AM, Jay Kreps wrote: Hey Ashish, > > Couple quick things: > > 1. You list as a rejected alternative "making the documentation the > source of truth for the protocol", but I think what you actually > describe in that section is global versio

[VOTE] KIP-35: Retrieving protocol version

2016-03-14 Thread Ashish Singh
Hey Guys, I would like to start voting process for *KIP-35: Retrieving protocol version*. The KIP is available here . Here