Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-05-16 Thread Mickael Maison
Thanks to everyone who voted and reviewed the KIP. The vote has passed with 3 binding votes (Rajini, Jun and Ismael) and 2 non-binding votes (Ted and Manikumar). Link to the PR: https://github.com/apache/kafka/pull/4829 On Tue, May 15, 2018 at 7:05 PM, Ismael Juma wrote: > Thanks for the KIP, +

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-05-15 Thread Ismael Juma
Thanks for the KIP, +1 (binding). Ismael On Wed, Apr 25, 2018 at 1:52 AM Mickael Maison wrote: > Hi, > > There has been no objections in the DISCUSS thread so I'd like to > start a vote on KIP-282: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-282%3A+Add+the+listener+name+to+the+aut

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-05-14 Thread Jun Rao
Hi, Mickael, Thanks for the KIP. +1 Jun On Wed, Apr 25, 2018 at 1:51 AM, Mickael Maison wrote: > Hi, > > There has been no objections in the DISCUSS thread so I'd like to > start a vote on KIP-282: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 282%3A+Add+the+listener+name+to+the+a

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-05-08 Thread Mickael Maison
Bumping as it still needs a few votes =) On Wed, Apr 25, 2018 at 8:24 PM, Mickael Maison wrote: > I've updated the KIP to simply expose the String value instead of the > full ListenerName object. > > On Wed, Apr 25, 2018 at 8:10 PM, Mickael Maison > wrote: >> Thanks for the heads up Ismael. In t

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Mickael Maison
I've updated the KIP to simply expose the String value instead of the full ListenerName object. On Wed, Apr 25, 2018 at 8:10 PM, Mickael Maison wrote: > Thanks for the heads up Ismael. In that case, I also think it makes > sense to just use the String representation. > > I'll update the KIP to re

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Mickael Maison
Thanks for the heads up Ismael. In that case, I also think it makes sense to just use the String representation. I'll update the KIP to reflect that change On Wed, Apr 25, 2018 at 7:25 PM, Rajini Sivaram wrote: > Sorry, I hadn't noticed that it was using `ListenerName`. I think we should > retur

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Rajini Sivaram
Sorry, I hadn't noticed that it was using `ListenerName`. I think we should return just a String. On Wed, Apr 25, 2018 at 7:02 PM, Ismael Juma wrote: > ListenerName is in an internal package, so we would have to move it before > exposing it in a public API. > > Ismael > > On Wed, 25 Apr 2018, 01

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Ismael Juma
ListenerName is in an internal package, so we would have to move it before exposing it in a public API. Ismael On Wed, 25 Apr 2018, 01:52 Mickael Maison, wrote: > Hi, > > There has been no objections in the DISCUSS thread so I'd like to > start a vote on KIP-282: > https://cwiki.apache.org/conf

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Manikumar
+1 (non-binding) On Wed, Apr 25, 2018 at 9:05 PM, Ted Yu wrote: > +1 > > On Wed, Apr 25, 2018 at 8:33 AM, Rajini Sivaram > wrote: > > > Hi Mickael, > > > > Thanks for the KIP. > > > > +1 (binding) > > > > On Wed, Apr 25, 2018 at 9:51 AM, Mickael Maison < > mickael.mai...@gmail.com> > > wrote: >

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Ted Yu
+1 On Wed, Apr 25, 2018 at 8:33 AM, Rajini Sivaram wrote: > Hi Mickael, > > Thanks for the KIP. > > +1 (binding) > > On Wed, Apr 25, 2018 at 9:51 AM, Mickael Maison > wrote: > > > Hi, > > > > There has been no objections in the DISCUSS thread so I'd like to > > start a vote on KIP-282: > > http

Re: [VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Rajini Sivaram
Hi Mickael, Thanks for the KIP. +1 (binding) On Wed, Apr 25, 2018 at 9:51 AM, Mickael Maison wrote: > Hi, > > There has been no objections in the DISCUSS thread so I'd like to > start a vote on KIP-282: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 282%3A+Add+the+listener+name+to+

[VOTE] KIP-282: Add the listener name to the authentication context

2018-04-25 Thread Mickael Maison
Hi, There has been no objections in the DISCUSS thread so I'd like to start a vote on KIP-282: https://cwiki.apache.org/confluence/display/KAFKA/KIP-282%3A+Add+the+listener+name+to+the+authentication+context Thanks