Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2018-01-11 Thread Matthias J. Sax
exact this reason: >>>>> https://issues.apache.org/jira/browse/KAFKA-6386 >>>>> >>>>> >>>>> -Matthias >>>>> >>>>> >>>>> On 12/20/17 3:33 PM, Jason Gustafson wrote: >>>>>> Hi Matthias, >&g

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2018-01-11 Thread Matthias J. Sax
>>>> On 12/20/17 3:33 PM, Jason Gustafson wrote: >>>>>> Hi Matthias, >>>>>> >>>>>> Isn't it a little weird to make these constructors public but not >>> also >>>>>> expose the corresponding client construc

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2018-01-08 Thread Matthias J. Sax
;> >>>> On 12/20/17 3:33 PM, Jason Gustafson wrote: >>>>> Hi Matthias, >>>>> >>>>> Isn't it a little weird to make these constructors public but not >> also >>>>> expose the corresponding client constructors that use them? >>&

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2018-01-08 Thread Ewen Cheslack-Postava
; > > > > > > -Jason > > > > > > > > On Tue, Dec 19, 2017 at 9:30 AM, Bill Bejeck > wrote: > > > > > > > >> +1 > > > >> > > > >> On Tue, Dec 19, 2017 at 12:09 PM, Guozhang Wang > > &g

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2018-01-03 Thread Colin McCabe
, Guozhang Wang > > >> wrote: > > >> > > >>> +1 > > >>> > > >>> On Tue, Dec 19, 2017 at 1:49 AM, Tom Bentley > > >>> wrote: > > >>> > > >>>> +1 > > >>>> > >

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2018-01-02 Thread Matthias J. Sax
che.org/jira/browse/KAFKA-6386 >>>>> >>>>> >>>>> -Matthias >>>>> >>>>> >>>>> On 12/20/17 3:33 PM, Jason Gustafson wrote: >>>>>> Hi Matthias, >>>>>> >>>>>>

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2018-01-02 Thread Ewen Cheslack-Postava
pose the corresponding client constructors that use them? > > >>> > > >>> -Jason > > >>> > > >>> On Tue, Dec 19, 2017 at 9:30 AM, Bill Bejeck > > wrote: > > >>> > > >>>> +1 > > >>>> > > &

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-21 Thread Jason Gustafson
ng client constructors that use them? > >>> > >>> -Jason > >>> > >>> On Tue, Dec 19, 2017 at 9:30 AM, Bill Bejeck > wrote: > >>> > >>>> +1 > >>>> > >>>> On Tue, Dec 19, 2017 at 12:09 PM

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-21 Thread Matthias J. Sax
>>>>> On Tue, Dec 19, 2017 at 1:49 AM, Tom Bentley >>>>> wrote: >>>>> >>>>>> +1 >>>>>> >>>>>> On 18 December 2017 at 23:28, Vahid S Hashemian < >>>>> vahidhashem...@us.ibm.com >>&

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-21 Thread Jason Gustafson
Dec 19, 2017 at 1:49 AM, Tom Bentley > >>> wrote: > >>> > >>>> +1 > >>>> > >>>> On 18 December 2017 at 23:28, Vahid S Hashemian < > >>> vahidhashem...@us.ibm.com > >>>>> &g

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-20 Thread Matthias J. Sax
ian < >>> vahidhashem...@us.ibm.com >>>>> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> Thanks for the KIP. >>>>> >>>>> --Vahid >>>>> >>>>> >>>>

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-20 Thread Matthias J. Sax
ian < >>> vahidhashem...@us.ibm.com >>>>> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> Thanks for the KIP. >>>>> >>>>> --Vahid >>>>> >>>>> >>>>

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-20 Thread Jason Gustafson
gt; > > > +1 > > > > > > > > Thanks for the KIP. > > > > > > > > --Vahid > > > > > > > > > > > > > > > > From: Ted Yu > > > > To: dev@kafka.apache.org > > > > D

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-19 Thread Bill Bejeck
gt; wrote: > > > > > +1 > > > > > > Thanks for the KIP. > > > > > > --Vahid > > > > > > > > > > > > From: Ted Yu > > > To: dev@kafka.apache.org > > > Date: 12/18/2017 02:45 PM > > > Subject:

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-19 Thread Guozhang Wang
> To: dev@kafka.apache.org > > Date: 12/18/2017 02:45 PM > > Subject: Re: [VOTE] KIP-243: Make ProducerConfig and > ConsumerConfig > > constructors public > > > > > > > > +1 > > > > nit: via "copy and past" an 'e'

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-19 Thread Tom Bentley
+1 On 18 December 2017 at 23:28, Vahid S Hashemian wrote: > +1 > > Thanks for the KIP. > > --Vahid > > > > From: Ted Yu > To: dev@kafka.apache.org > Date: 12/18/2017 02:45 PM > Subject:Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerCon

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-18 Thread Vahid S Hashemian
+1 Thanks for the KIP. --Vahid From: Ted Yu To: dev@kafka.apache.org Date: 12/18/2017 02:45 PM Subject:Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public +1 nit: via "copy and past" an 'e' is missing at the end. On Mon,

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-18 Thread Ted Yu
+1 nit: via "copy and past" an 'e' is missing at the end. On Mon, Dec 18, 2017 at 2:38 PM, Matthias J. Sax wrote: > Hi, > > I want to propose the following KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 243%3A+Make+ProducerConfig+and+ConsumerConfig+constructors+public > > > Thi

[VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-18 Thread Matthias J. Sax
Hi, I want to propose the following KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-243%3A+Make+ProducerConfig+and+ConsumerConfig+constructors+public This is a rather straight forward change, thus I skip the DISCUSS thread and call for a vote immediately. -Matthias signature.asc