Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-14 Thread Randall Hauch
On the advice of Ismael, I made a few minor changes to a few of the metrics to adhere to the new pattern of `-rate` and `-total` metric pairs defined in KIP-187 [1]: 1. Several of the "-rate" metrics were paired with a "-count" metric; the "-count" metrics were renamed to "-total". 2. Two "-rate"

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-13 Thread Randall Hauch
The KIP has passed with three binding +1 votes (Gwen, Sriram, Jason) and no -1 or +0 votes. Thanks to everyone for the feedback. On Tue, Sep 12, 2017 at 2:48 PM, Jason Gustafson wrote: > +1. Thanks for the KIP. > > On Tue, Sep 12, 2017 at 12:42 PM, Sriram Subramanian > wrote: > > > +1 > > > >

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Jason Gustafson
+1. Thanks for the KIP. On Tue, Sep 12, 2017 at 12:42 PM, Sriram Subramanian wrote: > +1 > > On Tue, Sep 12, 2017 at 12:41 PM, Gwen Shapira wrote: > > > My +1 remains :) > > > > On Tue, Sep 12, 2017 at 12:31 PM Randall Hauch wrote: > > > > > The KIP was modified (most changes due to reorganiza

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Sriram Subramanian
+1 On Tue, Sep 12, 2017 at 12:41 PM, Gwen Shapira wrote: > My +1 remains :) > > On Tue, Sep 12, 2017 at 12:31 PM Randall Hauch wrote: > > > The KIP was modified (most changes due to reorganization of metrics). > Feel > > free to re-vote if you dislike the changes. > > > > On Mon, Sep 11, 2017 a

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Gwen Shapira
My +1 remains :) On Tue, Sep 12, 2017 at 12:31 PM Randall Hauch wrote: > The KIP was modified (most changes due to reorganization of metrics). Feel > free to re-vote if you dislike the changes. > > On Mon, Sep 11, 2017 at 8:40 PM, Sriram Subramanian > wrote: > > > +1 > > > > On Mon, Sep 11, 201

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-12 Thread Randall Hauch
The KIP was modified (most changes due to reorganization of metrics). Feel free to re-vote if you dislike the changes. On Mon, Sep 11, 2017 at 8:40 PM, Sriram Subramanian wrote: > +1 > > On Mon, Sep 11, 2017 at 2:56 PM, Gwen Shapira wrote: > > > +1 > > > > Thanks for this. Can't wait for more c

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-11 Thread Sriram Subramanian
+1 On Mon, Sep 11, 2017 at 2:56 PM, Gwen Shapira wrote: > +1 > > Thanks for this. Can't wait for more complete monitoring for Connect. > > On Mon, Sep 11, 2017 at 7:40 AM Randall Hauch wrote: > > > I'd like to start the vote on KIP-196 to add metrics to the Kafka Connect > > framework so the wo

Re: [VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-11 Thread Gwen Shapira
+1 Thanks for this. Can't wait for more complete monitoring for Connect. On Mon, Sep 11, 2017 at 7:40 AM Randall Hauch wrote: > I'd like to start the vote on KIP-196 to add metrics to the Kafka Connect > framework so the worker processes can be measured. Details are here: > > > https://cwiki.ap

[VOTE] KIP-196: Add metrics to Kafka Connect framework

2017-09-11 Thread Randall Hauch
I'd like to start the vote on KIP-196 to add metrics to the Kafka Connect framework so the worker processes can be measured. Details are here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-196%3A+Add+metrics+to+Kafka+Connect+framework Thanks, and best regards. Randall