Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-03 Thread Jiangjie Qin
KIP-19 has been accepted with 4 binding +1s and 2 non-binding +1s. Thanks a lot! I really learned a lot from the discussions and also believe that they worth. Thanks, Jiangjie (Becket) Qin On 6/3/15, 8:09 AM, "Jun Rao" wrote: >+1. > >Thanks, > >Jun > >On Tue, Jun 2, 2015 at 3:13 PM, Jiangjie

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-03 Thread Jun Rao
+1. Thanks, Jun On Tue, Jun 2, 2015 at 3:13 PM, Jiangjie Qin wrote: > Ah, yes. Just changed it to ³request.timeout.ms². > > Thanks. > > Jiangjie (Becket) Qin > > On 6/2/15, 2:31 PM, "Jun Rao" wrote: > > >The wiki references "network.request.timeout.ms" in ProducerConfig. It > >should be "requ

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Jay Kreps
rename "max.block.ms" to " > max.send.block.ms > > "? > > > Something that indicates that it is being applied to the "send" API > > methods > > > exposed by KafkaProducer. > > > > > > Aditya > > > __

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Mayuresh Gharat
x.block.ms" to "max.send.block.ms > "? > > Something that indicates that it is being applied to the "send" API > methods > > exposed by KafkaProducer. > > > > Aditya > > > > From: Joel Koshy [j

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Ewen Cheslack-Postava
> > From: Joel Koshy [jjkosh...@gmail.com] > Sent: Tuesday, June 02, 2015 4:36 PM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-19 Add a request timeout to NetworkClient > > +1 > > On Tue, Jun 02, 2015 at 10:13:11PM +,

RE: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Aditya Auradkar
shy [jjkosh...@gmail.com] Sent: Tuesday, June 02, 2015 4:36 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-19 Add a request timeout to NetworkClient +1 On Tue, Jun 02, 2015 at 10:13:11PM +, Jiangjie Qin wrote: > Ah, yes. Just changed it to ³request.timeout.ms². > > Thanks. > >

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Joel Koshy
+1 On Tue, Jun 02, 2015 at 10:13:11PM +, Jiangjie Qin wrote: > Ah, yes. Just changed it to ³request.timeout.ms². > > Thanks. > > Jiangjie (Becket) Qin > > On 6/2/15, 2:31 PM, "Jun Rao" wrote: > > >The wiki references "network.request.timeout.ms" in ProducerConfig. It > >should be "request

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Jiangjie Qin
Ah, yes. Just changed it to ³request.timeout.ms². Thanks. Jiangjie (Becket) Qin On 6/2/15, 2:31 PM, "Jun Rao" wrote: >The wiki references "network.request.timeout.ms" in ProducerConfig. It >should be "request.timeout.ms", right? > >Thanks, > >Jun > >On Tue, Jun 2, 2015 at 2:06 PM, Jiangjie Qin

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Jun Rao
The wiki references "network.request.timeout.ms" in ProducerConfig. It should be "request.timeout.ms", right? Thanks, Jun On Tue, Jun 2, 2015 at 2:06 PM, Jiangjie Qin wrote: > Hi folks, > > Thanks a lot for all the input and help. It looks we do not have further > concerns on KIP-19. I’ve upda

Re: [VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Guozhang Wang
+1. Thanks Jiangjie! On Tue, Jun 2, 2015 at 2:06 PM, Jiangjie Qin wrote: > Hi folks, > > Thanks a lot for all the input and help. It looks we do not have further > concerns on KIP-19. I’ve updated the wiki page, let’s vote! > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+r

[VOTE] KIP-19 Add a request timeout to NetworkClient

2015-06-02 Thread Jiangjie Qin
Hi folks, Thanks a lot for all the input and help. It looks we do not have further concerns on KIP-19. I’ve updated the wiki page, let’s vote! https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient Thanks, Jiangjie (Becket) Qin