Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-25 Thread Eno Thereska
Just FYI: between feature freeze and code freeze we realised that the name of a method didn't match its Javadoc and implementation, so changed addLatencySensor -> addLatencyAndThroughputSensor in the KIP and code. Thanks Eno > On 11 Jan 2017, at 08:10, Eno Thereska wrote: > > Thank you, this

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-11 Thread Eno Thereska
Thank you, this KIP is now adopted. The votes were: Binding +1: Neha, Guozhang, Ismael, Sriram Non-binding +1: Bill, Matthias, Damian Thank you Eno & Aarti > On 10 Jan 2017, at 04:52, Neha Narkhede wrote: > > +1. Thanks Eno! > On Mon, Jan 9, 2017 at 1:05 PM Guozhang Wang wrote: > >> +1, than

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-09 Thread Neha Narkhede
+1. Thanks Eno! On Mon, Jan 9, 2017 at 1:05 PM Guozhang Wang wrote: > +1, thanks. > > On Jan 9, 2017 12:27 PM, "Ismael Juma" wrote: > > Thanks for the KIP, +1 on the latest update. > > Ismael > > On Fri, Jan 6, 2017 at 9:37 AM, Eno Thereska > wrote: > > > The discussion points for KIP-104 are a

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-09 Thread Guozhang Wang
+1, thanks. On Jan 9, 2017 12:27 PM, "Ismael Juma" wrote: Thanks for the KIP, +1 on the latest update. Ismael On Fri, Jan 6, 2017 at 9:37 AM, Eno Thereska wrote: > The discussion points for KIP-104 are addressed. At this point we'd like > to start the vote for it: > > https://cwiki.apache.or

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-09 Thread Ismael Juma
Thanks for the KIP, +1 on the latest update. Ismael On Fri, Jan 6, 2017 at 9:37 AM, Eno Thereska wrote: > The discussion points for KIP-104 are addressed. At this point we'd like > to start the vote for it: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 104%3A+Granular+Sensors+for

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-08 Thread Bill Bejeck
+1 On Sat, Jan 7, 2017 at 1:06 PM, Matthias J. Sax wrote: > +1 > > On 1/6/17 4:48 PM, Sriram Subramanian wrote: > > +1 > > > > On Fri, Jan 6, 2017 at 4:41 PM, Eno Thereska > wrote: > > > >> I light of the recent discussion on KIP-104 I've made changes to the KIP > >> to explicitly list all APIs

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-07 Thread Matthias J. Sax
+1 On 1/6/17 4:48 PM, Sriram Subramanian wrote: > +1 > > On Fri, Jan 6, 2017 at 4:41 PM, Eno Thereska wrote: > >> I light of the recent discussion on KIP-104 I've made changes to the KIP >> to explicitly list all APIs of the Metrics class for completion. I think >> it's fair to re-start the vot

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Sriram Subramanian
+1 On Fri, Jan 6, 2017 at 4:41 PM, Eno Thereska wrote: > I light of the recent discussion on KIP-104 I've made changes to the KIP > to explicitly list all APIs of the Metrics class for completion. I think > it's fair to re-start the vote on the KIP in light of the new discussion > for transparen

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Eno Thereska
I light of the recent discussion on KIP-104 I've made changes to the KIP to explicitly list all APIs of the Metrics class for completion. I think it's fair to re-start the vote on the KIP in light of the new discussion for transparency: https://cwiki.apache.org/confluence/display/KAFKA/KIP-104%3

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Sriram Subramanian
+1 On Fri, Jan 6, 2017 at 9:12 AM, Matthias J. Sax wrote: > +1 > > On 1/6/17 8:01 AM, Guozhang Wang wrote: > > +1 > > > > On Fri, Jan 6, 2017 at 5:05 AM, Bill Bejeck wrote: > > > >> +1 > >> > >> On Fri, Jan 6, 2017 at 5:57 AM, Damian Guy > wrote: > >> > >>> +1 > >>> > >>> On Fri, 6 Jan 2017 at

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Matthias J. Sax
+1 On 1/6/17 8:01 AM, Guozhang Wang wrote: > +1 > > On Fri, Jan 6, 2017 at 5:05 AM, Bill Bejeck wrote: > >> +1 >> >> On Fri, Jan 6, 2017 at 5:57 AM, Damian Guy wrote: >> >>> +1 >>> >>> On Fri, 6 Jan 2017 at 09:37 Eno Thereska wrote: >>> The discussion points for KIP-104 are addressed. At

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Guozhang Wang
+1 On Fri, Jan 6, 2017 at 5:05 AM, Bill Bejeck wrote: > +1 > > On Fri, Jan 6, 2017 at 5:57 AM, Damian Guy wrote: > > > +1 > > > > On Fri, 6 Jan 2017 at 09:37 Eno Thereska wrote: > > > > > The discussion points for KIP-104 are addressed. At this point we'd > like > > > to start the vote for it:

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Bill Bejeck
+1 On Fri, Jan 6, 2017 at 5:57 AM, Damian Guy wrote: > +1 > > On Fri, 6 Jan 2017 at 09:37 Eno Thereska wrote: > > > The discussion points for KIP-104 are addressed. At this point we'd like > > to start the vote for it: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 104%3A+

Re: [VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Damian Guy
+1 On Fri, 6 Jan 2017 at 09:37 Eno Thereska wrote: > The discussion points for KIP-104 are addressed. At this point we'd like > to start the vote for it: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-104%3A+Granular+Sensors+for+Streams > < > https://cwiki.apache.org/confluence/disp

[VOTE] KIP-104: Granular Sensors for Streams

2017-01-06 Thread Eno Thereska
The discussion points for KIP-104 are addressed. At this point we'd like to start the vote for it: https://cwiki.apache.org/confluence/display/KAFKA/KIP-104%3A+Granular+Sensors+for+Streams Thanks, Eno and