Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Hi Gwen,
A couple other thoughts:
services/templates
These are jinja2 templates which can be populated with values as desired.
Although currently many individual configs in various templates have preset
values, we can easily make these more parametrizable (presumably with
default values).
There
> There are loads of other improvements that could me
> made too -- for example, I'd love seeing Docker support, which would make
> running tests way cheaper/simpler.
Haha, that was my first thought when I saw Vagrant in there - why not Docker? :)
I didn't realize we already had Vagrant integratio
Github either lets you do inline comments on the diff ("Files Changed" tab)
or on the entire commit ("Conversation"). One of the things review board
does right that's a bit frustrating in Github his that you can't group a
bunch of comments into a single review and post it all at once (and get
only
I'm unclear on the directory structure and few high level things (and
I can't figure out how to comment on more than a single line in
github):
tests/kafkatest - isn't it redundant? do we expect any non-kafka tests?
services/templates - those are basically all configuration files to be
used by the
Awesome, thanks :)
On Tue, Jun 23, 2015 at 10:32 AM, Geoffrey Anderson wrote:
> Hi Gwen,
>
> That is indeed the plan, and my understanding is that the merge script
> Ismael has been working on helps committers with this step.
>
> I'm trying out the Github flow roughly as outlined here:
> http://m
Hi Gwen,
That is indeed the plan, and my understanding is that the merge script
Ismael has been working on helps committers with this step.
I'm trying out the Github flow roughly as outlined here:
http://mail-archives.apache.org/mod_mbox/kafka-dev/201504.mbox/%3ccad5tkzab-hkey-zcr8x4wtxawybxpojx6
Thanks, I indeed missed the original :)
Is the plan to squash the commits and merge a pull request with single
commit that matches the JIRA #?
This will be more in line with how commits were organized until now
and will make life much easier when cherry-picking.
Gwen
On Mon, Jun 22, 2015 at 1:58
Hi,
I'm pinging the dev list regarding KAFKA-2276 (KIP-25 initial patch) again
since it sounds like at least one person I spoke with did not see the
initial pull request.
Pull request: https://github.com/apache/kafka/pull/70/
JIRA: https://issues.apache.org/jira/browse/KAFKA-2276
Thanks!
Geoff
GitHub user granders opened a pull request:
https://github.com/apache/kafka/pull/70
Kafka 2276
Initial patch for KIP-25
Note that to install ducktape, do *not* use pip to install ducktape.
Instead:
```
$ git clone g...@github.com:confluentinc/ducktape.git
$
10 matches
Mail list logo
