[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka-site/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...

2016-05-17 Thread ijuma
Github user ijuma commented on the pull request: https://github.com/apache/kafka-site/pull/13#issuecomment-219895048 Thanks, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...

2016-05-17 Thread RyanCoonan
Github user RyanCoonan commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/13#discussion_r63553295 --- Diff: coding-guide.html --- @@ -19,7 +19,7 @@ Scala -We are following the style guide given http://davetron5000.github.com/scala

[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...

2016-05-17 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/13#discussion_r63552659 --- Diff: coding-guide.html --- @@ -19,7 +19,7 @@ Scala -We are following the style guide given http://davetron5000.github.com/scala-styl

[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...

2016-05-17 Thread RyanCoonan
Github user RyanCoonan commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/13#discussion_r63551060 --- Diff: coding-guide.html --- @@ -19,7 +19,7 @@ Scala -We are following the style guide given http://davetron5000.github.com/scala

[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...

2016-05-17 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/13#discussion_r63518630 --- Diff: coding-guide.html --- @@ -19,7 +19,7 @@ Scala -We are following the style guide given http://davetron5000.github.com/scala-styl

[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...

2016-05-14 Thread RyanCoonan
GitHub user RyanCoonan opened a pull request: https://github.com/apache/kafka-site/pull/13 MINOR: Replace Scala style guide PDF link with scala-lang.org link The style guide PDF currently linked to is mostly empty with just "Moved to " links. You can merge this pull request into a