[GitHub] kafka-site issue #78: MINOR: Add header items

2017-09-29 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/78 @joel-hamill I'm concerned that the horizontal nav you're introducing here is going to cause some usability issues and actually conflicts with some work that's been going on with the Streams la

[GitHub] kafka-site issue #78: MINOR: Add header items

2017-09-15 Thread joel-hamill
Github user joel-hamill commented on the issue: https://github.com/apache/kafka-site/pull/78 @manjuapu ---

[GitHub] kafka-site issue #78: MINOR: Add header items

2017-09-15 Thread ewencp
Github user ewencp commented on the issue: https://github.com/apache/kafka-site/pull/78 @joel-hamill Something like this should work: ``` diff --git a/css/styles.css b/css/styles.css index 1e75e91..2aa587e 100644 --- a/css/styles.css +++ b/css/styles.css @@

[GitHub] kafka-site issue #78: MINOR: Add header items

2017-09-15 Thread joel-hamill
Github user joel-hamill commented on the issue: https://github.com/apache/kafka-site/pull/78 @dguy i don't think these files are in https://github.com/apache/kafka/tree/trunk/docs. these are changes specifically to the header/footer/nav. ---

[GitHub] kafka-site issue #78: MINOR: Add header items

2017-09-15 Thread dguy
Github user dguy commented on the issue: https://github.com/apache/kafka-site/pull/78 @joel-hamill thanks for the PR. However... these changes should be made against the Apache Kafka project - otherwise we run the risk of losing them. ---

[GitHub] kafka-site issue #78: MINOR: Add header items

2017-09-14 Thread joel-hamill
Github user joel-hamill commented on the issue: https://github.com/apache/kafka-site/pull/78 ping for review @guozhangwang @dguy ---