Re: [Discussion] KIP-34 Add Partitioner Change Listener to Partitioner Interface

HI Becket, Thanks for answering and providing feedback. I will withdraw KIP and put into rejected section. Thanks, Bhavesh On Mon, Sep 21, 2015 at 9:53 AM, Jiangjie Qin wrote: > Hey Bhavesh, > > I kind of think this metadata change capture logic should be implemented by > each user by themse

Re: [Discussion] KIP-34 Add Partitioner Change Listener to Partitioner Interface

Hey Bhavesh, I kind of think this metadata change capture logic should be implemented by each user by themselves for the following reasons: 1. Most user do not really care about partition change. Adding the logic/interface to default partitioner means for users who don't care about the partition

Re: [Discussion] KIP-34 Add Partitioner Change Listener to Partitioner Interface

HI Jiagjie, Thanks for valuable feedback. 1) Thread Coordination for Change of partitions could be issue. I do agree with you that coordination between the application thread and sender thread would be tough one. The only concern I had was to share the same logic you had described among all th

Re: [Discussion] KIP-34 Add Partitioner Change Listener to Partitioner Interface

Hey Bhavesh, I think it is useful to notify the user about the partition change. The problem of having a listener in producer is that it is hard to guarantee the synchronization. For example, consider the following sequence: 1. producer sender thread refreshes the metadata with partition change.

[Discussion] KIP-34 Add Partitioner Change Listener to Partitioner Interface

Hi Kafka Dev Team, I would like you get your feedback about adding yet another method or API call to onPartitionsChange( ) to Partitioner Interface to get notify about partition changes upon metadata refresh. This will allow custom logic (implementor of Partitioner) to be notified if partition ow