Thanks Chris,
It makes sense to call out the cleaning up of existing offsets in the KIP.
I have made the change and will initiate the voting in a day.
Regards,
Ashwin
On Tue, Dec 12, 2023 at 6:57 PM Chris Egerton
wrote:
> Hi Ashwin,
>
> LGTM! One small adjustment I'd suggest but we don't have
Hi Ashwin,
LGTM! One small adjustment I'd suggest but we don't have to block on--it
may be clearer to put "Wipe all existing offsets for the connector" in
between steps 2 and 3 of the proposed changes section.
Cheers,
Chris
On Mon, Dec 11, 2023 at 11:24 PM Ashwin
wrote:
> Thanks for pointing
Thanks for pointing this out Chris.
I have updated the KIP with the correct sequence of steps.
Thanks,
Ashwin
On Wed, Dec 6, 2023 at 11:48 PM Chris Egerton
wrote:
> Hi Ashwin,
>
> Regarding point 4--I think this is still a bit unwise. When workers pick up
> a new connector config from the conf
Hi Ashwin,
Regarding point 4--I think this is still a bit unwise. When workers pick up
a new connector config from the config topic, they participate in a
rebalance. It may be safe to write offsets during that rebalance, but in
the name of simplicity, do you think we can write the offsets for the
Hello Chris,
Thanks for the quick and detailed review. Please see my responses below
High-level thoughts:
1. I had not thought of this till now, thanks for pointing it out. I
would lean towards the second option of cleaning previous offsets as
it will result in the fewer surprises for the user.
Oh, one more thing--can we add the KIP to the list of KIPs?
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-KIPsunderdiscussion
On Mon, Dec 4, 2023 at 10:33 AM Chris Egerton wrote:
> Hi Ashwin,
>
> Thanks for the KIP! This would be a nice s
Hi Ashwin,
Thanks for the KIP! This would be a nice simplification to the process for
migrating connectors enabled by KIP-980, and would also add global support
for a feature I've seen implemented by hand in at least a couple connectors
over the years.
High-level thoughts:
1. If there are lefto
Hi all,
I'd like to begin discussion on KIP-995 which proposes to allow users
to specify initial offset as part of the request to create a connector
https://cwiki.apache.org/confluence/display/KAFKA/KIP-995%3A+Allow+users+to+specify+initial+offsets+while+creating+connectors
During the discussion
