Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-03-14 Thread Federico Valeri
Bumping this thread as KIP-641 is now adopted. Thanks Fede On Thu, Feb 16, 2023 at 11:13 AM Federico Valeri wrote: > > On Thu, Feb 16, 2023 at 10:26 AM Luke Chen wrote: > > > > Hi Federico, > > > > 1. Sounds good. > > I think you should make it clear in the KIP. > > > > We only have one tool wi

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Federico Valeri
On Thu, Feb 16, 2023 at 10:26 AM Luke Chen wrote: > > Hi Federico, > > 1. Sounds good. > I think you should make it clear in the KIP. > > We only have one tool with this issue (kafka.tools.StateChangeLogMerger), > which is tracked in KAFKA-7735 > .

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Luke Chen
Hi Federico, 1. Sounds good. I think you should make it clear in the KIP. We only have one tool with this issue (kafka.tools.StateChangeLogMerger), which is tracked in KAFKA-7735 . This has been broken since 2.0 release, so it means that there is

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Federico Valeri
Hi Luke, thanks for the feedback. On Thu, Feb 16, 2023 at 9:33 AM Luke Chen wrote: > > Hi Federico, > > Thanks for the KIP. > It's really helpful to have a general guideline for tools migration so that > contributors and reviewers can be clear what to be expected. > > One question: > In the broke

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Luke Chen
Hi Federico, Thanks for the KIP. It's really helpful to have a general guideline for tools migration so that contributors and reviewers can be clear what to be expected. One question: In the broker link tool, you said we should directly deprecate it. But does that mean this tool will keep broken?

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Federico Valeri
Sorry for the spam. I had some issue with my mail client. On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri wrote: > > Hi everyone, > > I opened KIP-906 to have some guidelines around tools migration: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines > > Le

[DISCUSS] KIP-906 Tools migration guidelines

2023-02-15 Thread Federico Valeri
Hi everyone, I opened KIP-906 to have some guidelines around tools migration: https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines Let me know if you have any feedback or suggestions. Thanks Fede

[DISCUSS] KIP-906 Tools migration guidelines

2023-02-15 Thread Federico Valeri
Hi everyone, I opened KIP-906 to have some guidelines around tools migration: https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines Let me know if you have any feedback or suggestions. Thanks Fede

[DISCUSS] KIP-906 Tools migration guidelines

2023-02-15 Thread Federico Valeri
Hi everyone, I opened KIP-906 to have some guidelines around tools migration: https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines Let me know if you have any feedback or suggestions. Thanks Fede