Hey Tom,
Thank you for your comments!
1. I have updated the language in the KIP and added relevant links.
2. The `plugin.path.discovery` name was intended to communicate that it
controlled the interpretation of the `plugin.path` configuration, but I can
see how that can be confusing.
I suppose t
Hi Greg,
Thanks for the KIP. Overall I think using service loading would be a
worthwhile improvement.
1. "Both of these are well-established Java interfaces for which public
documentation should be readily available." I see no harm in adding a well
chosen link or two just to save readers unfamil
Hi Greg,
Thanks for the updates. This is looking great. A few minor questions:
1. The description for the list command in the plugin path CLI states that
it'll show "Whether the class is discoverable via scanning". Are there any
cases where a plugin found by the CLI won't be discoverable via scan
Chris,
Thanks for the comments!
1. I've updated the script to sync-manifests [--keep-not-found] with your
described semantics.
2. I've pushed all of the deprecation decisions to a follow-up KIP that can
take place after an intervening release.
I hope that this feature has a high enough ROI that
Hi Greg,
Thanks for the updates. Unless stated below, I agree with your responses. A
few more thoughts:
1. IMO it's not worth it to have separate commands for adding/removing
manifests, mostly because it adds complexity to the tool and might make it
harder for users to understand. I think a singl
Hi Greg,
On Tue, Jan 24, 2023 at 2:48 AM Greg Harris
wrote:
>
> Federico,
>
> Thanks for taking a look!
>
> > I was just wondering if we should use a better script name like
> > "connect-convert-to-service-provider.sh" or something like this
>
> I agree that the current name is not ideal, while t
Federico,
Thanks for taking a look!
> I was just wondering if we should use a better script name like
> "connect-convert-to-service-provider.sh" or something like this
I agree that the current name is not ideal, while the current name
describes part of what it is doing, it does not describe all
Hi Greg,
Thanks for the KIP! This part of Connect has been due for an update for a
while, it's nice to see it getting some attention. I especially like how
the migration plan is broken down into affected personas; makes review
easier and, hopefully, makes the feature easier to understand for affec
Hi Greg, this looks like a useful change to me.
I was just wondering if we should use a better script name like
"connect-convert-to-service-provider.sh" or something like this, and
maybe add a --dry-run option.
On Tue, Jan 17, 2023 at 8:45 PM Greg Harris
wrote:
>
> Hi all!
>
> I'd like to start
Hi all!
I'd like to start a discussion about
https://cwiki.apache.org/confluence/display/KAFKA/KIP-898%3A+Modernize+Connect+plugin+discovery
.
Thanks!
Greg Harris
10 matches
Mail list logo
