Re: [DISCUSS] KIP-886 Add Client Producer and Consumer Builders

2022-12-17 Thread John Roesler
Hello Dan, Thanks for the KIP! I just saw the vote thread, took a look at the KIP, and had some questions. Sorry for the delay in reviewing. It can be a hassle, but the KIP document should specify the exact public interfaces you are proposing. This helps to prevent a gap between what reviewer

Re: [DISCUSS] KIP-886 Add Client Producer and Consumer Builders

2022-11-16 Thread Dan S
Hello all, I've gotten great feedback from Knowles here, and from Luke Chen on the jira, so thanks to both so much. This is my first KIP, and I'm pretty new to contributing to kafka, so I'd like to learn a little bit more about the process and the way things usually work. Should I open a PR first?

Re: [DISCUSS] KIP-886 Add Client Producer and Consumer Builders

2022-11-10 Thread Knowles Atchison Jr
This would be helpful. For our own client library wrappers we implemented this functionality for any type with defaults for and consumers/producers. On Thu, Nov 10, 2022, 6:35 PM Dan S wrote: > Hello all, > > I think that adding builders for the producer and the consumer in kafka > client woul

[DISCUSS] KIP-886 Add Client Producer and Consumer Builders

2022-11-10 Thread Dan S
Hello all, I think that adding builders for the producer and the consumer in kafka client would make it much easier for developers to instantiate new producers and consumers, especially if they are using an IDE with intellisense, and using the IDE to navigate to the documentation which could be ad