Re: [DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Thanks for the updates Sagar! On Thu, Feb 10, 2022 at 5:59 PM Sagar wrote: > Hi All, > > As discussed above, this KIP would be discarded and the new metric proposed > here would be added to KIP-770 as the need to add a new metric was > discovered when working on it. > > Thanks! > Sagar. > > On T

Re: [DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Hi All, As discussed above, this KIP would be discarded and the new metric proposed here would be added to KIP-770 as the need to add a new metric was discovered when working on it. Thanks! Sagar. On Thu, Feb 10, 2022 at 9:54 AM Sagar wrote: > Hi Guozhang, > > Sure. I will add it to the KIP. >

Re: [DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Hi Guozhang, Sure. I will add it to the KIP. Thanks! Sagar. On Mon, Feb 7, 2022 at 6:22 AM Guozhang Wang wrote: > Since the PR is reopened and we are going to re-merged the fixed PRs, what > about just adding that as part of the KIP as the addendum? > > On Fri, Feb 4, 2022 at 2:13 AM Sagar wr

Re: [DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Since the PR is reopened and we are going to re-merged the fixed PRs, what about just adding that as part of the KIP as the addendum? On Fri, Feb 4, 2022 at 2:13 AM Sagar wrote: > Thanks Sophie/Guozhang. > > Yeah I could have amended the KIP but it slipped my mind when Guozhang > proposed this i

Re: [DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Thanks Sophie/Guozhang. Yeah I could have amended the KIP but it slipped my mind when Guozhang proposed this in the PR. Later on, the PR was merged and KIP was marked as adopted so I thought I will write a new one. I know the PR had been reopened now :p . I dont have much preference on a new KIP v

Re: [DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Thanks Sagar for proposing the KIP, and Sophie for sharing your thoughts. Here're my 2c: I think I agree with Sophie for making the two metrics (both the added and the newly proposed) on INFO level since we are always calculating them anyways. Regarding the level of the cache-size though, I'm thin

Re: [DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Hey Sagar, thanks for the KIP! And yes, all metrics are considered part of the public API and thus require a KIP to add (or modify, etc...) Although in this particular case, you could probably make a good case for just considering it as an update to the original KIP which added the analogous metr

[DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

Hi All, I would like to open a discussion thread on the following KIP: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390 PS: This is about introducing a new metric and I am assuming that it requires a KIP. If that isn't the case, I can close it. Thanks! Sagar.