Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-28 Thread David Jacot
oinLeader(...) method, or adding a new > > boolean > > > > > > parameter to the performAssignment(...) method? The reason I ask > > is because > > > > > > I raised KIP-795 a few weeks back, which aims to add a public API > > for > > > > > > Abstr

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-28 Thread Luke Chen
> AbstractCoordinator, which might change (or not) with this KIP. > > > > > > > > > > I see you also mentioned there's some discussions regarding a new > consumer > > > > > protocol. Is this being discussed somewhere else? I'm curious to

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-28 Thread David Jacot
lse? I'm curious to know > > > > how > > > > would it work with other systems (like Kafka Connect or Schema Registry) > > > > that rely on the rebalance protocol to handle resource assignments. > > > > > > > > Apologies i

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-26 Thread David Jacot
balance protocol to handle resource assignments. > > > > > > Apologies in advance if these questions are off-topic for the discussion > > > at hand. > > > > > > Regards, > > > Hector > > > > > > From: dev@kafka.apache.org At: 01/24

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-26 Thread David Jacot
t; > > > Regards, > > Hector > > > > From: dev@kafka.apache.org At: 01/24/22 09:08:58 UTC-5:00To: > > dev@kafka.apache.org > > Subject: Re: [DISCUSS] KIP-814: Static membership protocol should let the > > leader skip assignment > > > > Hey Jason

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-25 Thread Jason Gustafson
ctor > > From: dev@kafka.apache.org At: 01/24/22 09:08:58 UTC-5:00To: > dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-814: Static membership protocol should let the > leader skip assignment > > Hey Jason, > > Thanks for your comments. > > Regarding your first point.

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-24 Thread Hector Geraldino (BLOOMBERG/ 919 3RD A)
at rely on the rebalance protocol to handle resource assignments. Apologies in advance if these questions are off-topic for the discussion at hand. Regards, Hector From: dev@kafka.apache.org At: 01/24/22 09:08:58 UTC-5:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-814: Static membershi

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-24 Thread David Jacot
Hey Jason, Thanks for your comments. Regarding your first point. Yes, you have it right. Let me complement the KIP to be clearer. Regarding your second point. That is right. New partitions would not be detected while the leader is down. It is definitely not ideal but that seems acceptable to me,

Re: [DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-21 Thread Jason Gustafson
Hey David, Thanks for the proposal. This was a tricky bug and I think your approach is probably the best way forward. It would be helpful to add a little more detail to the proposal. When the coordinator detects that the static leader is returning, it will set `skipAssignment` to true in the `Joi

[DISCUSS] KIP-814: Static membership protocol should let the leader skip assignment

2022-01-19 Thread David Jacot
Hi folks, I'd like to start a discussion for KIP-814: Static membership protocol should let the leader skip assignment. This is a small extension to the static membership protocol to address KAFKA-13435. The KIP is here: https://cwiki.apache.org/confluence/x/C5-kCw. Please let me know what you t