Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2024-07-29 Thread Mickael Maison
Hi, I've not received a reply from Gunnar since last month, so I'll pick this KIP up. Thanks, Mickael On Tue, Jun 18, 2024 at 6:01 PM Mickael Maison wrote: > > Hi Gunnar, > > I think this KIP would be a great addition to Kafka Connect but it > looks like it's been abandoned. > > Are you stil

Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2024-06-18 Thread Mickael Maison
Hi Gunnar, I think this KIP would be a great addition to Kafka Connect but it looks like it's been abandoned. Are you still interested in working on this? If you need some time or help, that's fine, just let us know. If not, no worries, I'm happy to pick it up if needed. Thanks, Mickael On Wed,

Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2021-12-22 Thread Tom Bentley
Hi Gunnar, Thanks for the KIP, especially the careful reasoning about compatibility. I think this would be a useful improvement. I have a few observations, which are all about how we effectively communicate the contract to implementers: 1. I think it would be good for the Javadoc to give a bit mo

Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2021-12-21 Thread Chris Egerton
Hi Gunnar, Thanks, this looks great. I'm ready to cast a non-binding on the vote thread when it comes. One small non-blocking nit: I like that you call out that the new validation steps will take place when a connector gets registered or updated. IMO this is important enough to be included in the

Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2021-12-21 Thread Gunnar Morling
Hey Chris, Thanks a lot for reviewing this KIP and your comments! Some more answers inline. Am Di., 7. Dez. 2021 um 23:49 Uhr schrieb Chris Egerton : > Hi Gunnar, > > Thanks for the KIP! The section on backwards compatibility is especially > impressive and was enjoyable to read. > Excellent, th

Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2021-12-07 Thread Chris Egerton
Hi Gunnar, Thanks for the KIP! The section on backwards compatibility is especially impressive and was enjoyable to read. Overall I like the direction of the KIP (and in fact just ran into a situation yesterday where it would be valuable). I only have one major thought: could we add similar valid

[DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2021-11-24 Thread Gunnar Morling
Hey all, I would like to propose a KIP for Apache Kafka Connect which adds validation support for SMT-related configuration options: https://cwiki.apache.org/confluence/display/KAFKA/KIP-802%3A+Validation+Support+for+Kafka+Connect+SMT+Options This feature allows users to make sure an SMT is con