Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

Hi all, I have made some edits to the KIP to expose controller metrics on standby controllers. This may help the user troubleshoot misbehaving standby controllers since the metrics of standby controllers could be lagging behind the metrics of the active controller. Here are the changes to the KIP

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

Thanks for the suggestions Colin, I updated the KIP, here are the changes: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=188743985&selectedPageVersions=14&selectedPageVersions=13 Regards, Ryan Dielhenn On 2021/09/07 16:46:13, "Colin McCabe" wrote: > Thanks for the

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

Thanks for the update. You still have a lot of places that are written misleadingly. For example, > Pre-Kraft brokers currently register 0 for every controller metric. Someone reading this would wonder, if they're always 0, then why do we have these metrics? Please phrase this better to indicat

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

Thank you Ron & Colin for the comments. I have updated the KIP with the suggested changes: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=188743985&selectedPageVersions=6&selectedPageVersions=5 Regards, Ryan Dielhenn On 2021/08/31 22:41:21, "Colin McCabe" wrote: >

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

Hi Ryan, Thanks for the KIP. Hmm, we don't really use the term "zookeeper brokers." That is confusing since ZK and Kafka are separate services. I would suggest a term like pre-KRaft brokers. > Zookeeper brokers currently register 0 for every controller metric. It's not 0 for every broker, is

Re: [DISCUSS] KIP-771: KRaft broker should not expose controller metrics

Thanks for the KIP, Ryan. I agree this makes sense. It also reflects the state of affairs right now: KRaft nodes that do not have the controller role currently do not expose these metrics. Assuming this KIP ends up being accepted, we would then close KAFKA-13140 and its associated PR https://git

[DISCUSS] KIP-771: KRaft broker should not expose controller metrics

Hello kafka devs, I would like to start a discussion on a KIP I have created to change how controller metrics are exposed for KRaft brokers. Here is the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP+771%3A+KRaft+brokers+should+not+expose+controller+metrics Regards, Ryan Dielhenn