Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-27 Thread Jason Gustafson
Thanks all for the comments. It sounds like this is not too controversial, so I will move this to a vote tomorrow or the next day. Best, Jason On Tue, Apr 27, 2021 at 1:54 AM David Jacot wrote: > Thanks for the KIP, Jason. The proposed changes sound good to me. > > Best, > David > > On Tue, Apr

Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-27 Thread David Jacot
Thanks for the KIP, Jason. The proposed changes sound good to me. Best, David On Tue, Apr 27, 2021 at 2:52 AM Satish Duggana wrote: > Tthanks Jason for the clarification. > > On Tue, 27 Apr 2021 at 05:42, Jason Gustafson > wrote: > > > > Hi Satish, > > > > Typically we update the upgrade notes

Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-26 Thread Satish Duggana
Tthanks Jason for the clarification. On Tue, 27 Apr 2021 at 05:42, Jason Gustafson wrote: > > Hi Satish, > > Typically we update the upgrade notes when we merge the config change > itself. Supposing the KIP is approved, I will add a note to the jira to > ensure we do not forget. > > Thanks, > Jas

Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-26 Thread Jason Gustafson
Hi Satish, Typically we update the upgrade notes when we merge the config change itself. Supposing the KIP is approved, I will add a note to the jira to ensure we do not forget. Thanks, Jason On Mon, Apr 26, 2021 at 10:02 AM Satish Duggana wrote: > Hi Jason, > Thanks for the detailed KIP. Both

Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-26 Thread Satish Duggana
Hi Jason, Thanks for the detailed KIP. Both the changes including the default session timeout change and min/max group session timeout are great improvements. It is good to add this behavior in the upgrade docs. How do we track these to be updated in the upgrade docs? Best, Satish. On Sat, 24 A

Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-23 Thread Ismael Juma
Thanks for the KIP, +1. Ismael On Fri, Apr 23, 2021 at 9:29 AM Jason Gustafson wrote: > Hi All, > > I've created a KIP to change the default consumer session timeout as well > as some related behavior: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-735%3A+Increase+default+consumer+se

Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-23 Thread Bill Bejeck
Hi Jason, Thanks for the well-written KIP. >From the reasons outlined in the KIP, I think this a great change. -Bill On Fri, Apr 23, 2021 at 2:52 PM Sophie Blee-Goldman wrote: > Hey Jason, > > Thanks for the KIP, I think increasing the default session timeout would be > great. The choice of >

Re: [DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-23 Thread Sophie Blee-Goldman
Hey Jason, Thanks for the KIP, I think increasing the default session timeout would be great. The choice of 45s sounds reasonable to me. -Sophie On Fri, Apr 23, 2021 at 9:29 AM Jason Gustafson wrote: > Hi All, > > I've created a KIP to change the default consumer session timeout as well > as s

[DISCUSS] KIP-735: Increase default consumer session timeout

2021-04-23 Thread Jason Gustafson
Hi All, I've created a KIP to change the default consumer session timeout as well as some related behavior: https://cwiki.apache.org/confluence/display/KAFKA/KIP-735%3A+Increase+default+consumer+session+timeout. Have a look and let me know what you think. -Jason