Bump!
On 2021/04/09 18:41:17 Ryanne Dolan wrote:
> Hey y'all, I'd like to draw you attention to a new KIP:
>
>
https://cwiki.apache.org/confluence/display/KAFKA/KIP-731%3A+Record+Rate+Limiting+for+Kafka+Connect
>
> Lemme know what you think. Thanks!
>
> Ryanne
>
Thanks Mickael.
> 1) if you set rate.limiters to MyRateLimiter you would
> not have to set these 2 configs.
>
True. That may be motivation to adopt Tom's suggestion re config.
> 2) Should we have a
> ByteRateLimiter?
>
That would be ideal, but it is difficult in practice, since ConnectRecord
Hi Ryanne,
Thanks for the KIP! Sorry for the delay, I finally took some time to
take a look and I have a few questions:
1) record.rate.limit, record.batch.rate.limit are listed as Connector
configurations. If I understand correctly they are actually
configurations of RecordRateLimiter, and Record
Hey Tom, thanks for taking a look.
> It's a bit weird that there's a separate start(Time) method
Good call, I think we can use a second constructor instead.
> No metrics for batch rates?
Good call. TBH I assumed there would already be put/poll rates, but looking
again I don't see them. Will add
Hi Ryanne,
Thanks for the KIP. I can see this would be useful.
1. Can you elaborate on the life cycle of the RateLimiter interface (in the
Javadoc)? In particular it's not clear to me how calls to accumulate() and
throttleTime() can be interleaved (I assume arbitrarily).
2. It's a bit weird that
Hey y'all, I've expanded the scope of this KIP slightly to include a
pluggable interface, RateLimiter.
After implementing this a few different ways, it's clear that the
configuration story is actually simpler with a pluggable model.
Out-of-the-box, we have just two configuration properties to twea
Bump!
On Fri, Apr 9, 2021, 1:41 PM Ryanne Dolan wrote:
> Hey y'all, I'd like to draw you attention to a new KIP:
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-731%3A+Record+Rate+Limiting+for+Kafka+Connect
>
> Lemme know what you think. Thanks!
>
> Ryanne
>
Hey y'all, I'd like to draw you attention to a new KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-731%3A+Record+Rate+Limiting+for+Kafka+Connect
Lemme know what you think. Thanks!
Ryanne
