Re: [DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-22 Thread Colin McCabe
Hi Andrei, Kafka intentionally sets TCP_NODELAY in order to disable Nagle's algorithm. The reason is because Nagle's algorithm can cause to long latencies in Kafka RPC. Wikipedia explains the problem: > [Nagle's] algorithm interacts badly with TCP delayed acknowledgments > (delayed ACK), a

Re: [DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-21 Thread Chia-Ping Tsai
hi Andrei Thanks for this find and KIP. Two questions is left. 1) Is there significant side effect if we disable it? For example, does it cause higher latency in your cluster? If there is no obvious side effect, could we disable it by default? 2) As you mentioned that most packets belong to in

Re: [DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-19 Thread Andrei Iatsuk
Hi David, Thanks for your comment. Client connections are insignificant on my test cluster. But I can add this setting just in case. Best regards, Andrei > On 19 Mar 2021, at 23:19, David Jacot wrote: > > Hi Andrei, > > Thanks for the KIP. > > Should we consider adding the setting in the cl

Re: [DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-19 Thread David Jacot
Hi Andrei, Thanks for the KIP. Should we consider adding the setting in the clients as well? I think that it is also enabled by default in the clients. Could it be useful? Best, David Le ven. 19 mars 2021 à 13:41, Ismael Juma a écrit : > Hi Andrei, > > I would start the vote on Monday if ther

Re: [DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-19 Thread Ismael Juma
Hi Andrei, I would start the vote on Monday if there are no comments. Ismael On Fri, Mar 19, 2021 at 5:36 AM Andrei Iatsuk wrote: > No comments yet. I don’t know this is good or not. May I start voting? > > > On 17 Mar 2021, at 18:32, Andrei Iatsuk wrote: > > > > Hello everyone, > > > > I wou

Re: [DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-19 Thread Andrei Iatsuk
No comments yet. I don’t know this is good or not. May I start voting? > On 17 Mar 2021, at 18:32, Andrei Iatsuk wrote: > > Hello everyone, > > I would like to start a discussion on KIP-723, which propose adding a Kafka > Config property with TCP_NODELAY socket option flag, that currently har

[DISCUSS] KIP-723: Add socket.tcp.no.delay property to Kafka Config

2021-03-17 Thread Andrei Iatsuk
Hello everyone, I would like to start a discussion on KIP-723, which propose adding a Kafka Config property with TCP_NODELAY socket option flag, that currently hardcoded in true. https://cwiki.apache.org/confluence/display/KAFKA/KIP-723%3A+Add+socket.tcp.no.delay+property+to+Kafka+Config Best