Re: [DISCUSS] KIP-604: Remove ZooKeeper Flags from the Administrative Tools

2020-05-05 Thread Sönke Liebau
Thanks for making the changes Colin, lgtm! On Mon, 4 May 2020 at 23:13, Colin McCabe wrote: > Hi Sönke, > > You're right on both counts. Thanks for the corrections. > > Thinking about this more, I think we should just remove > kafka-preferred-replica-election.sh. It just duplicates > kafka-lea

Re: [DISCUSS] KIP-604: Remove ZooKeeper Flags from the Administrative Tools

2020-05-04 Thread Colin McCabe
Hi Sönke, You're right on both counts. Thanks for the corrections. Thinking about this more, I think we should just remove kafka-preferred-replica-election.sh. It just duplicates kafka-leader-election.sh, and it has been deprecated for some time. I changed the KIP. cheers, Colin On Mon, M

Re: [DISCUSS] KIP-604: Remove ZooKeeper Flags from the Administrative Tools

2020-05-04 Thread Sönke Liebau
Hi Colin, thanks for the kip, lgtm overall with two small comments: 1. you mention kafka-leader-election.sh in the list of tools to remove the ZooKeeper option from, but I think the command never had that option, as it was introduced in KIP-460 specifically to replace the deprecated command with

[DISCUSS] KIP-604: Remove ZooKeeper Flags from the Administrative Tools

2020-04-30 Thread Colin McCabe
Hi all, I posted a KIP about removing the deprecated --zookeeper flags from our administrative tools. Check it out here: https://cwiki.apache.org/confluence/x/kRARCQ best, Colin