Hi Mickael,
Thanks! This looks great, +1 non-binding.
Cheers,
Chris
On Sun, May 3, 2020 at 4:13 AM Mickael Maison
wrote:
> Thanks Chris for the feedback.
>
> 1. I've added sample output for the 3 formatters
> 2. Good idea, instead of deleting the existing trait, let's mark it as
> deprecated
Thanks Chris for the feedback.
1. I've added sample output for the 3 formatters
2. Good idea, instead of deleting the existing trait, let's mark it as
deprecated and make it extend the new interface. I've updated to the
KIP.
I've also opened a draft PR: https://github.com/apache/kafka/pull/8604
Hi Mickael,
The KIP looks great and the additional formatters seem like excellent tools
for debugging and diving into the internals of Mirror Maker 2.0. I've got a
few thoughts on the proposed changes:
1. Would it be possible to provide examples for what the actual output
might look like when the
Thanks Mickael, this will be very useful.
Ryanne
On Thu, Apr 16, 2020 at 11:44 AM Mickael Maison
wrote:
> Hi,
>
> I have submitted a small KIP to provide Formatters for the
> MirrorMaker2 internal topics.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-597%3A+MirrorMaker2+internal+t
Hi,
I have submitted a small KIP to provide Formatters for the
MirrorMaker2 internal topics.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-597%3A+MirrorMaker2+internal+topics+Formatters
Looking forward to your feedback. Thanks
