Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality

2019-10-28 Thread Brian Byrne
Hi Stanislav, That's fair, I wouldn't imagine it being necessary to add --describe for all broker-loggers, but was intended mainly for consistency with the other entity types. One might find it useful to grep for certain entries, or it's possible that the output is improved to only show non-defaul

Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality

2019-10-26 Thread Stanislav Kozlovski
Hey Brian, Thank you for the KIP, any step towards KIP-500 is a great idea! I wanted to discuss the need for a --describe on all the broker-loggers resource at once. The output is very verbose - I count more than 150 lines. Although since I imagine more options to describe internal state wouldn't

Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality

2019-10-22 Thread Brian Byrne
Sure - updated. Thanks, Brian On Tue, Oct 22, 2019 at 4:02 PM Colin McCabe wrote: > Hi Brian, > > Thanks for the KIP! This looks like a nice cleanup. It will be good to > be able to perform these operations without direct ZK access. > > I guess this is a nitpick, but for the operations propos

Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality

2019-10-22 Thread Colin McCabe
Hi Brian, Thanks for the KIP! This looks like a nice cleanup. It will be good to be able to perform these operations without direct ZK access. I guess this is a nitpick, but for the operations proposed for later, it might be nice to have a different color, like yellow, to indicate that we'll

[DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality

2019-10-22 Thread Brian Byrne
Hello all, I wrote a KIP about expanding the ConfigCommand's functionality when not accessing ZooKeeper directly, i.e. when --bootstrap-servers is specified instead of --zookeeper. This should bring the two into parity. There's also a bit of bikeshedding about additional flags for shortening enti