Re: [DISCUSS] KIP-53 Add custom policies for reconnect attempts to NetworkdClient

2016-07-08 Thread Dana Powers
Thanks for the confirmation, Ismael. I will write something up for further discussion. -Dana On Jul 5, 2016 4:43 PM, "Ismael Juma" wrote: > Hi Dana, > > Thanks for the PR. Technically, a (simple) KIP is required when proposing > new configs. > > Ismael > > On Sun, Jun 19, 2016 at 7:42 PM, Dana P

Re: [DISCUSS] KIP-53 Add custom policies for reconnect attempts to NetworkdClient

2016-07-05 Thread Ismael Juma
Hi Dana, Thanks for the PR. Technically, a (simple) KIP is required when proposing new configs. Ismael On Sun, Jun 19, 2016 at 7:42 PM, Dana Powers wrote: > I took a stab at implementing a simplified exponential + randomized > backoff policy here: https://github.com/apache/kafka/pull/1523 > >

Re: [DISCUSS] KIP-53 Add custom policies for reconnect attempts to NetworkdClient

2016-06-19 Thread Dana Powers
I took a stab at implementing a simplified exponential + randomized backoff policy here: https://github.com/apache/kafka/pull/1523 Rather than changing public interfaces / using plugins, it just adds a new client configuration "reconnect.backoff.max" that can be used to enable increasing backoff w

Re: [DISCUSS] KIP-53 Add custom policies for reconnect attempts to NetworkdClient

2016-05-02 Thread Guozhang Wang
For the specific problem of connection storm, randomized with normal distribution at specified mean as "reconnect.backoff.ms" has been proved pretty well. The most recent usage of it in my mind is RAFT, and it turns out pretty effective in eliminating leader-election storms. Guozhang On Fri, Apr

Re: [DISCUSS] KIP-53 Add custom policies for reconnect attempts to NetworkdClient

2016-04-29 Thread Ewen Cheslack-Postava
I'll agree w/ Jay and point out that the implementations of ReconnectionPolicy provided built-in with that driver are Constant, Exponential, and Counting. Constant and exponential can be combined with the right set of policy config parameters. I'm curious if there's a real need for something else,

Re: [DISCUSS] KIP-53 Add custom policies for reconnect attempts to NetworkdClient

2016-04-04 Thread Jay Kreps
If I understand the problem we are fixing is a connection storm where when a new broker comes online it is overwhelmed with connections. In general we try hard to avoid plugins where possible. Maybe instead of adding another plugin interface we could just directly solve this problem by doing some

[DISCUSS] KIP-53 Add custom policies for reconnect attempts to NetworkdClient

2016-04-04 Thread Florian Hussonnois
Hi Kafka Team, I have made a new Kafka Improvement Proposal. https://cwiki.apache.org/confluence/display/KAFKA/KIP-53+-+Add+custom+policies+for+reconnect+attempts+to+NetworkdClient This is my first proposal so I don't know if I have given enough information. Also I have already proposed an implem