Re: [DISCUSS] KIP-522: Update BrokerApiVersionsCommand to use AdminClient

2019-10-23 Thread Mickael Maison
Thanks Colin for the feedback. I'm discarding this KIP and I've closed both https://issues.apache.org/jira/browse/KAFKA-5214 and https://issues.apache.org/jira/browse/KAFKA-5723 with links to this discussion. On Mon, Sep 23, 2019 at 7:18 PM Colin McCabe wrote: > > Hi Mickael, > > The brokerApiVe

Re: [DISCUSS] KIP-522: Update BrokerApiVersionsCommand to use AdminClient

2019-09-23 Thread Colin McCabe
Hi Mickael, The brokerApiVersions command was added for administrators, as a debugging tool. It wasn't added so that applications could hard-code version dependencies. Hard-coding different application behaviors in different versions was exactly what we were attempting to avoid. In the examp

Re: [DISCUSS] KIP-522: Update BrokerApiVersionsCommand to use AdminClient

2019-09-20 Thread Mickael Maison
Thank you Colin for the context. Before opening the KIP I had a quick look and found the JIRAs you linked but saw no traces of the concerns you mentioned. I also found the PR but could not find an associated KIP. The example I provided in the KIP (incrementalAlterConfigs/alterConfigs) is one of t

Re: [DISCUSS] KIP-522: Update BrokerApiVersionsCommand to use AdminClient

2019-09-18 Thread Colin McCabe
Hi Mickael, Just to give you the context, this is something that's been discussed several times. Check out https://issues.apache.org/jira/browse/KAFKA-5214 and https://issues.apache.org/jira/browse/KAFKA-5723 , as well as this pull request: https://github.com/apache/kafka/pull/3012 I think th

[DISCUSS] KIP-522: Update BrokerApiVersionsCommand to use AdminClient

2019-09-16 Thread Mickael Maison
Hi all, I've created a KIP to add listApiVersions support to the AdminClient. This will allow us to update the BrokerApiVersionsCommand tool and more importantly allow users to detect API support and build flexible client applications: https://cwiki.apache.org/confluence/display/KAFKA/KIP-522%3A+U