Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

Moved this KIP into status "inactive". Feel free to resume and any time. -Matthias On 7/9/19 3:51 PM, Dongjin Lee wrote: > Hi Matthias, > > Have you thought about this issue? > > Thanks, > Dongjin > > On Wed, Jun 19, 2019 at 5:07 AM Dongjin Lee wrote: > >> Hello. >> >> I just uploaded the dr

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

Hi Matthias, Have you thought about this issue? Thanks, Dongjin On Wed, Jun 19, 2019 at 5:07 AM Dongjin Lee wrote: > Hello. > > I just uploaded the draft implementation of the three proposed > alternatives. > > - Type A: define a close timeout constant - > https://github.com/dongjinleekr/kafka

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

Hello. I just uploaded the draft implementation of the three proposed alternatives. - Type A: define a close timeout constant - https://github.com/dongjinleekr/kafka/tree/feature/KAFKA-7996-a - Type B: Provide a new configuration option, 'close.wait.ms' - https://github.com/dongjinleekr/kafka/tre

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

I just updated the KIP document reflecting what I found about the clients API inconsistency and Matthias's comments. Since it is now obvious that modifying the default close timeout for the client is not feasible, the updated document proposes totally different alternatives. (see Rejected Alternati

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

Thanks for digging into the back ground. I think it would be good to get feedback from people who work on clients, too. -Matthias On 5/19/19 12:58 PM, Dongjin Lee wrote: > Hi Matthias, > > I investigated the inconsistencies between `close` semantics of `Producer`, > `Consumer`, and `AdminClie

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

Hi Matthias, I investigated the inconsistencies between `close` semantics of `Producer`, `Consumer`, and `AdminClient`. And I found that this inconsistency was intended. Here are the details: The current `KafkaConsumer#close`'s default timeout, 30 seconds, was introduced in KIP-102 (0.10.2.0)[^1]

Re: [DISCUSS] KIP-459: Improve KafkaStreams#close

Thanks for the KIP. Overall, I agree with the sentiment of the KIP. The current semantics of `KafkaStreams#close(timeout)` are not well defined. Also the general client inconsistencies are annoying. > This KIP make any change on public interfaces; however, it makes a subtle > change to the exis

[DISCUSS] KIP-459: Improve KafkaStreams#close

Hi dev, I would like to start the discussion of KIP-459: Improve KafkaStreams#close . This proposal is originated from the issue reported via community slack, KAFKA-7996