Re: [DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-04-12 Thread Randall Hauch
Thanks for the proposal and the PR request, Valeria. I've been working with Valeria on this PR, so it's not surprising I'm in favor of this KIP and improvement so that users can easily mask values with specific replacement values with the same primitive type. This proposal has been open for over

Re: [DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-03-28 Thread Valeria Vasylieva
вт, 19 мар. 2019 г. в 17:59, Valeria Vasylieva : > Hi Adam, > > Thank you for your response! > Dear community members, do you have any other thoughts on this KIP? Would > be great if you share them! > > Regards, > > Valeria > > сб, 16 мар. 2019 г. в 18:16, Adam Bellemare : > >> Hi Valeria >> >> I

Re: [DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-03-19 Thread Valeria Vasylieva
Hi Adam, Thank you for your response! Dear community members, do you have any other thoughts on this KIP? Would be great if you share them! Regards, Valeria сб, 16 мар. 2019 г. в 18:16, Adam Bellemare : > Hi Valeria > > I am thinking that a full map function via configuration is very unlikely

Re: [DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-03-16 Thread Adam Bellemare
Hi Valeria I am thinking that a full map function via configuration is very unlikely to be feasible. At that point, it would be best for the user to create their own custom transformation. I think that since your function is indeed just an extension of masking that it is reasonable as presented.

Re: [DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-03-15 Thread Valeria Vasylieva
Hi Adam, Thank you for your interest. Here is the list of currently supported transformations in Connect: https://kafka.apache.org/documentation/#connect_transforms. As I can see, there is no "map" transformation in this list and all other SMTs do not support functionality described in a KIP. I ca

Re: [DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-03-15 Thread Adam Bellemare
Hi Valeria Thanks for the KIP. I admit my knowledge on Kafka Connect transforms is a bit rusty, however - Is there any other way to currently achieve this same functionality outlined in your KIP using existing transforms? Thanks On Thu, Mar 14, 2019 at 12:05 PM Valeria Vasylieva < valeri

Re: [DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-03-14 Thread Valeria Vasylieva
Dear community members, I would be very grateful if you leave any feedback on this KIP. It will help me to understand if change is useful or not and to decide on further actions. Thank you in advance, Valeria пн, 11 мар. 2019 г. в 13:20, Valeria Vasylieva : > Hi All, > > I would like to start a

[DISCUSS] KIP-437: Custom replacement for MaskField SMT

2019-03-11 Thread Valeria Vasylieva
Hi All, I would like to start a discussion about adding new functionality to MaskField SMT. The existing implementation allows to mask out any field value with the null equivalent of the field type. I suggest to add a possibility to provide a literal replacement for the field. This way you can ma