Sorry, probably not ideal to just be seeing this now given KIP deadline,
but in general straightforward ones where we expect things to be
uncontroversial, I think its fine to kick off a vote thread. Worst case we
have people re-file votes if something substantial changes in the proposal.
-Ewen
On
Considering this KIP is straightforward, what do you think about kicking off a
vote? Or does it need more discussion time?
Regards,
Randall
> On May 18, 2018, at 4:30 PM, Ewen Cheslack-Postava wrote:
>
> Yeah, the usefulness of short seems questionable, but int is probably a
> large enough ran
Yeah, the usefulness of short seems questionable, but int is probably a
large enough range for some identifiers (e.g. we use an int in schema
registry). But yeah, I don't really have a problem with having Converters
for each of the existing serdes just for symmetry and since presumably
somebody fin
Thanks, Ewen.
You make several good points, and I've updated the KIP to hopefully address
your comments. I think the symmetry with the Kafka serdes is useful, so
I've kept all 5 converters in the KIP.
Interestingly, perhaps the short and int converters (with the reduced
ranges) are not necessaril
Just a couple of minor points that don't really affect the implementation:
* For nulls, let's just mention the underlying serializers already support
this. I'm actually not sure why they should/need to, but given they do,
let's just defer to that implementation.
* I'm not sure where Float and Doub
Thanks Randall for the KIP. I think it will be super useful and looks
pretty straightforward to me.
Thanks
Magesh
On Thu, May 17, 2018 at 4:15 PM, Randall Hauch wrote:
> I'd like to start discussion of a very straightforward proposal for Connect
> to add converters for the basic primitive numbe
I'd like to start discussion of a very straightforward proposal for Connect
to add converters for the basic primitive number types: integer, short,
long, double, and float. Here is the KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-305%3A+Add+Connect+primitive+number+converters
As men
