Thanks for the KIP, +1 (binding).
Ismael
On Fri, Sep 8, 2017 at 6:00 PM, Ted Yu wrote:
> Hi,
> Please take a look at:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 197+Connect+REST+API+should+include+the+connector+type+
> when+describing+a+connector
>
> Thanks
>
Awesome turnaround time :) Trying to get another committer to take a look
so we can get this in for the next release.
-Ewen
On Mon, Sep 11, 2017 at 8:30 PM, Ted Yu wrote:
> Updated KIP-197 with the reference to KIP-151
>
> On Mon, Sep 11, 2017 at 8:24 PM, Ewen Cheslack-Postava
> wrote:
>
> > Y
Updated KIP-197 with the reference to KIP-151
On Mon, Sep 11, 2017 at 8:24 PM, Ewen Cheslack-Postava
wrote:
> Yeah, this all seems reasonable to me as well. Even if there are other
> places we should add this info, these seem like the really useful ones.
>
> re: the enum generating lowercase, th
Yeah, this all seems reasonable to me as well. Even if there are other
places we should add this info, these seem like the really useful ones.
re: the enum generating lowercase, that came in KIP-151 (which was the
first to expose this info, and technically is enough to not *require* this
change, b
Looks good to me! Thanks again!
I say go ahead and ask for a vote in a new thread.
Randall
On Fri, Sep 8, 2017 at 6:22 PM, Ted Yu wrote:
> Lowercase constants are generated by the enum.
>
> Updated KIP again.
>
> On Fri, Sep 8, 2017 at 4:08 PM, Randall Hauch wrote:
>
> > One more thing. I won
Lowercase constants are generated by the enum.
Updated KIP again.
On Fri, Sep 8, 2017 at 4:08 PM, Randall Hauch wrote:
> One more thing. I wonder if we should use lowercase constants for the types
> rather than mixed case: "sink" and "source" (rather than "Sink" and
> "Source"). Thoughts?
>
> O
One more thing. I wonder if we should use lowercase constants for the types
rather than mixed case: "sink" and "source" (rather than "Sink" and
"Source"). Thoughts?
On Fri, Sep 8, 2017 at 6:02 PM, Ted Yu wrote:
> Updated the KIP accordingly.
>
> Cheers
>
> On Fri, Sep 8, 2017 at 3:57 PM, Randall
Updated the KIP accordingly.
Cheers
On Fri, Sep 8, 2017 at 3:57 PM, Randall Hauch wrote:
> Hi, Ted. Thanks for the quick turn around.
>
> I didn't remember that the response to the "/connectors/{name}/config" is
> the actual configuration, so we probably shouldn't add "type" there. Sorry
> abou
Hi, Ted. Thanks for the quick turn around.
I didn't remember that the response to the "/connectors/{name}/config" is
the actual configuration, so we probably shouldn't add "type" there. Sorry
about that.
And in the "/connector/{name}/status" response, I wonder if it would be
better to embed the "
Thanks for the reminder, Randall.
I have modified the KIP to include these two endpoints.
On Fri, Sep 8, 2017 at 11:00 AM, Randall Hauch wrote:
> Hi, Ted.
>
> Thanks for creating this KIP and for working on the implementation. The
> proposal looks great for the "/connectors/{name}" endpoint, bu
Hi, Ted.
Thanks for creating this KIP and for working on the implementation. The
proposal looks great for the "/connectors/{name}" endpoint, but there are
several others that we need to consider as well so that the responses are
all consistent. In particular, look at "/connectors/{name}/status" an
Hi,
Please take a look at:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-197+Connect+REST+API+should+include+the+connector+type+when+describing+a+connector
Thanks
12 matches
Mail list logo
