Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-07-17 Thread Abhishek Mendhekar
Thanks for your response. >> > > Even though, as you suggested, this metric can be calculated using >> other >> > > present metrics, I still feel that adding the 'number of partitions' >> > > metrics helps in better representing a Kafk

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-07-17 Thread Abhishek Mendhekar
nting a Kafka cluster. > > > I don't feel too strong about it though (in case it is considered a > > > redundant metrics based on your argument). > > > > > > Thanks. > > > --Vahid > > > > > > > > > > > > > > > F

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-07-17 Thread Becket Qin
don't feel too strong about it though (in case it is considered a > > redundant metrics based on your argument). > > > > Thanks. > > --Vahid > > > > > > > > > > From: Abhishek Mendhekar > > To: dev@kafka.apache.org > > Date

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-07-12 Thread Abhishek Mendhekar
though (in case it is considered a > redundant metrics based on your argument). > > Thanks. > --Vahid > > > > > From: Abhishek Mendhekar > To: dev@kafka.apache.org > Date: 07/10/2017 01:43 PM > Subject:Re: [DISCUSS] KIP-168: Add TotalTopicCount metr

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-07-10 Thread Vahid S Hashemian
(in case it is considered a redundant metrics based on your argument). Thanks. --Vahid From: Abhishek Mendhekar To: dev@kafka.apache.org Date: 07/10/2017 01:43 PM Subject: Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster Hi Vahid, Thanks for the response. Kafka

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-07-10 Thread Abhishek Mendhekar
there is already an offline partition count metric in the > controller, but no total partition count. > > Thanks. > --Vahid > > > > From: Abhishek Mendhekar > To: dev@kafka.apache.org > Date: 06/16/2017 09:09 AM > Subject:[DISCUSS] KIP-168: Add TotalTop

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-07-10 Thread Abhishek Mendhekar
Thanks Dong! On Wed, Jun 28, 2017 at 9:46 AM, Dong Lin wrote: > Hey Abhishek, > > GlobalTopicCount sounds good to me. > > Thanks, > Dong > > On Wed, Jun 28, 2017 at 8:39 AM, Abhishek Mendhekar < > abhishek.mendhe...@gmail.com> wrote: > > > Hi Joel, > > > > Thanks for your comments. > > > > To ke

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-28 Thread Dong Lin
Hey Abhishek, GlobalTopicCount sounds good to me. Thanks, Dong On Wed, Jun 28, 2017 at 8:39 AM, Abhishek Mendhekar < abhishek.mendhe...@gmail.com> wrote: > Hi Joel, > > Thanks for your comments. > > To keep it consistent as well as clear my suggestion is to change the > TopicCount to GlobalTopi

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-28 Thread Vahid S Hashemian
. --Vahid From: Abhishek Mendhekar To: dev@kafka.apache.org Date: 06/16/2017 09:09 AM Subject:[DISCUSS] KIP-168: Add TotalTopicCount metric per cluster Hi Kafka Dev, I created KIP-168 to propose adding a metric to emit total topic count in a cluster. The metric will be emited by

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-28 Thread Abhishek Mendhekar
Hi Joel, Thanks for your comments. To keep it consistent as well as clear my suggestion is to change the TopicCount to GlobalTopicCount. This makes it fairly consistent (if not completely) as well as makes it unambiguous in what it means. Dong, Let me know if this sounds good. Best, Abhishek O

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-26 Thread Joel Koshy
+1 on the original KIP I actually prefer TotalTopicCount because it makes it clearer that it is a cluster-wide count. OfflinePartitionsCount is global to the cluster (but it is fairly clear that the controller is SoT on that). TopicCount on the other hand could be misread as a local count since Par

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-22 Thread Abhishek Mendhekar
Hi Kafka Dev, Below is the link to the update KIP proposal. https://cwiki.apache.org/confluence/display/KAFKA/KIP-168%3A+Add+TopicCount+metric+per+cluster Thanks, Abhishek On Wed, Jun 21, 2017 at 3:55 PM, Abhishek Mendhekar < abhishek.mendhe...@gmail.com> wrote: > Hi Dong, > > Thanks for the su

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-21 Thread Abhishek Mendhekar
Hi Dong, Thanks for the suggestion! I think TopicCount sounds reasonable to me and it definitely seems consistent with the other metric names. I will update the proposal to reflect this change. Thanks, Abhishek On Wed, Jun 21, 2017 at 2:17 PM, Dong Lin wrote: > Hey Abhishek, > > I think the m

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-21 Thread Dong Lin
Hey Abhishek, I think the metric is useful. Sorry for being late on this. I am wondering if TopicCount is a better name than TotalTopicCount, given that we currently have metric with names OfflinePartitionsCount, LeaderCount, PartitionCount etc. Thanks, Dong On Fri, Jun 16, 2017 at 9:09 AM, Abhi

Re: [DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-18 Thread Onur Karaman
This metric sounds simple and useful. +1 On Fri, Jun 16, 2017 at 9:09 AM, Abhishek Mendhekar < abhishek.mendhe...@gmail.com> wrote: > Hi Kafka Dev, > > I created KIP-168 to propose adding a metric to emit total topic count > in a cluster. The metric will be emited by the controller. > > The KIP

[DISCUSS] KIP-168: Add TotalTopicCount metric per cluster

2017-06-16 Thread Abhishek Mendhekar
Hi Kafka Dev, I created KIP-168 to propose adding a metric to emit total topic count in a cluster. The metric will be emited by the controller. The KIP can be found here (https://cwiki.apache.org/confluence/display/KAFKA/KIP-168%3A+Add+TotalTopicCount+metric+per+cluster) and the assciated JIRA im