Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Guozhang Wang
Sounds great, thanks! On Wed, May 10, 2017 at 10:43 AM, Xavier Léauté wrote: > I'll be driving the implementation as well. Unless there are specific > concerns about the implementation, I mainly wrote the KIP to agree on the > additional public interfaces. > > Current window store fetch operatio

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-10 Thread Xavier Léauté
I'll be driving the implementation as well. Unless there are specific concerns about the implementation, I mainly wrote the KIP to agree on the additional public interfaces. Current window store fetch operations already rely on range scanning & filtering the relevant keys in the underlying state s

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-09 Thread Guozhang Wang
Thanks, the KIP sounds good to me. There is no implementation proposal in the JIRA / KIP yet, would you like you drive the implementation also? Guozhang On Tue, May 9, 2017 at 8:29 AM, Xavier Léauté wrote: > I updated the KIP to reflect Michal's comment. Unless there are any further > comments

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-09 Thread Xavier Léauté
I updated the KIP to reflect Michal's comment. Unless there are any further comments, I will initiate a vote this evening. On Mon, May 8, 2017 at 11:01 AM Xavier Léauté wrote: > That sounds reasonable, Michal. Given the underlying implementation uses > the same segmented bytes store I don't thin

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-08 Thread Xavier Léauté
That sounds reasonable, Michal. Given the underlying implementation uses the same segmented bytes store I don't think it should be too difficult to add. On Mon, May 8, 2017 at 2:04 AM Michal Borowiecki < michal.borowie...@openbet.com> wrote: > Hi Xavier, > > I like your KIP. Do you think the same

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-08 Thread Michal Borowiecki
Hi Xavier, I like your KIP. Do you think the same should apply to session stores? IMHO, all three should be on par wrt the ability to query key ranges (although I understand the implementation concerns for windowed stores are more involved than for normal key value stores). Thanks, Michal

[DISCUSS] KIP-155 Add range scan for windowed state stores

2017-05-08 Thread Xavier Léauté
Hi everyone, I am proposing to add the ability to range scan windowed state stores in Kafka Streams. The required interface changes are relatively minimal and follow our existing conventions for state stores. Let me know if that sounds reasonable. https://cwiki.apache.org/confluence/display/KAFKA