Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2018-04-07 Thread Ted Yu
Can you start another thread with [VOTE] in the subject ? Original message From: 东方甲乙 <254479...@qq.com> Date: 4/7/18 6:10 AM (GMT-08:00) To: dev Subject: Re: [DISCUSS] KIP-148: Add a  connect timeout for client Hi all, Do you have further concerns or questions abou

Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2018-04-07 Thread ????????
"dev"; ????: Re?? [DISCUSS] KIP-148: Add a connect timeout for client Hi Colin, I think the exponential backoff should still apply, thanks for the explanation. thanks, David -- -- ??: "Colin McCabe";; : 2017??6

Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-16 Thread ????????
uot;";<254479...@qq.com>; > : 2017??6??4??(??) 6:05 > ??????: "dev"; > > : Re?? [DISCUSS] KIP-148: Add a connect timeout for client > > > > >I guess one obvious question is, how does this interact with retries? > >Does i

Re: 回复:Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-12 Thread Colin McCabe
17年6月4日(星期天) 晚上6:05 > 收件人: "dev"; > > 主题: Re: [DISCUSS] KIP-148: Add a connect timeout for client > > > > >I guess one obvious question is, how does this interact with retries? > >Does it result in a failure getting delivered to the end user more > &g

??????Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-10 Thread ????????
-- -- ??: "";<254479...@qq.com>; : 2017??6??4??(??) 6:05 ??: "dev"; ????: Re?? [DISCUSS] KIP-148: Add a connect timeout for client >I guess one obvious question is, how does this interact w

Re?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-06-04 Thread ????????
??: "Colin McCabe";; : 2017??5??31??(??) 2:44 ??????: "dev"; ????: Re: [DISCUSS] KIP-148: Add a connect timeout for client On Mon, May 29, 2017, at 15:46, Guozhang Wang wrote: > On Wed, May 24, 2017 at 9:59 AM, Colin McCabe wrote: > > > On Tue, May 23, 20

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-30 Thread Colin McCabe
; > > On Mon, May 22, 2017 at 11:21 AM, Ismael Juma < > > ism...@juma.me.uk> > > > > wrote: > > > > > > > > > > > > > > > > > Rajini, > > > > > > > > > > > > > > > > > > For this to ha

RE?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-29 Thread ????????
> > > > > > > > connected and connecting phases when shutdown is unclean. > > > You could > > > > > > > > still > > > > > > > > > > use the timeout to ensure that next metadata request is > sent > > > to &g

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-29 Thread Guozhang Wang
t; > default request.timeout.ms for the consumer and fix the > > > underlying > > > > > > > reason > > > > > > > > why it is a little over 5 minutes at the moment. > > > > > > > > > > > > > > > &g

Re?? Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-29 Thread ????????
David -- -- ??: "Rajini Sivaram";; : 2017??5??23??(??) 11:57 ??: ""<254479...@qq.com>; ????: "dev"; ????: Re: Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client Hi David, The only iss

RE?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-28 Thread ????????
-- -- ??: "Guozhang Wang";; : 2017??5??24??(??) 10:07 ??: "dev@kafka.apache.org"; ????: Re: [DISCUSS] KIP-148: Add a connect timeout for client I think using a single config to cover end-to-end latency with connecting and request round-trip may not be best

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-24 Thread Colin McCabe
avid, > > > > > > > > > > > > > > > > Sorry, what I meant was: Can you reuse the existing > > configuration > > > > > > option > > > > > > > > request.timeout,ms , instead of adding a new config and add the > >

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Guozhang Wang
e > > > > > behaviour > > > > > > > that you have proposed in the KIP for the connection phase > using this > > > > > > > timeout? I think the timeout for connection is useful. I am > not sure > > > > we > > > > > > > need anoth

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Colin McCabe
t? I think the timeout for connection is useful. I am not sure > > > we > > > > > > need another configuration option to implement it. > > > > > > > > > > > > Regards, > > > > > > > > > > > > Rajini > > >

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Colin McCabe
t; > > > > > > > > > > > > > > > > In out test env, QA shutdown one of the leader node, the producer > > > > send > > > > > > the > > > > > > > request will timeout and close the node's connect

Re: Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Rajini Sivaram
dler these different cases. > > Thanks, > David > > -- 原始邮件 -- > *发件人:* "Rajini Sivaram" ; > *发送时间:* 2017年5月23日(星期二) 19:27 > *收件人:* "dev" ; > *主题:* Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client > > > G

Re:Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread 东方甲乙
, David -- 原始邮件 -- 发件人: "Rajini Sivaram" ; 发送时间: 2017年5月23日(星期二) 19:27 收件人: "dev" ; 主题: Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client Guozhang, At the moment we don't have a connect timeout. And the behaviour suggested in the

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-23 Thread Rajini Sivaram
M, 东方甲乙 <254479...@qq.com> wrote: > > > > > > > > > Hi Rajini. > > > > > > > > > > When kafka node' machine is shutdown or network is closed, the > > > connecting > > > > > phase could not use the r

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Simon Souter
eout.ms, because the client > haven't > > > > send a req yet. And no response for the nio, the selector will not > > > close > > > > the connect, so it will not choose other good node to get the > metadata. > > > > > > > > &g

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Guozhang Wang
When kafka node' machine is shutdown or network is closed, the > > > connecting > > > > > phase could not use the request.timeout.ms, because the client > > haven't > > > > > send a req yet. And no response for the nio, the selector will > not &g

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Ismael Juma
req yet. And no response for the nio, the selector will not > > > close > > > > the connect, so it will not choose other good node to get the > metadata. > > > > > > > > > > > > Thanks > > > > David > > > > >

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
ood node to get the metadata. > > > > > > > > > Thanks > > > David > > > > > > -- 原始邮件 -- > > > *发件人:* "Rajini Sivaram" ; > > > *发送时间:* 2017年5月22日(星期一) 20:17 > > > *收件人

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Ismael Juma
s > > David > > > > -------------- 原始邮件 ---------- > > *发件人:* "Rajini Sivaram" ; > > *发送时间:* 2017年5月22日(星期一) 20:17 > > *收件人:* "dev" ; > > *主题:* Re: [DISCUSS] KIP-148: Add a connect timeout for client > > > > > &g

Re: Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
ini Sivaram" ; > *发送时间:* 2017年5月22日(星期一) 20:17 > *收件人:* "dev" ; > *主题:* Re: [DISCUSS] KIP-148: Add a connect timeout for client > > > Hi David, > > Is there a reason why you wouldn't want to use request.timeout.ms as the > timeout parameter for connectio

Re:Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread 东方甲乙
to get the metadata. Thanks David -- 原始邮件 -- 发件人: "Rajini Sivaram" ; 发送时间: 2017年5月22日(星期一) 20:17 收件人: "dev" ; 主题: Re: [DISCUSS] KIP-148: Add a connect timeout for client Hi David, Is there a reason why you wouldn't want to use request.

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-22 Thread Rajini Sivaram
or can find the > connecting is timeout and close the connection. It seems the currently the > timeout value passed in `selector.poll()` > seems can not do this. > > > Thanks, > David > > > > > > > ---------- 原始邮件 ------ > 发件人: "Guozha

RE?? [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-21 Thread ????????
--- ??: "Guozhang Wang";; : 2017??5??16??(??) 1:51 ??: "dev@kafka.apache.org"; ????: Re: [DISCUSS] KIP-148: Add a connect timeout for client Hi David, I may be a bit confused before, just clarifying a few things: 1. As you mentioned, a client

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-15 Thread Guozhang Wang
ave two > parameters to control the connecting phrase behavior and the connected > phrase behavior, do you think so? > > > Thanks, > > > David > > > > > -- 原始邮件 ------ > 发件人: "Guozhang Wang";; > 发送时间: 2017年5月6日(星期六) 上午7:52 &

RE: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-14 Thread ????????
nks, David -- -- ??: "Guozhang Wang";; : 2017??5??6??(??) 7:52 ??: "dev@kafka.apache.org"; ????: Re: [DISCUSS] KIP-148: Add a connect timeout for client Hello David, Thanks for the KIP. For the described

Re: [DISCUSS] KIP-148: Add a connect timeout for client

2017-05-05 Thread Guozhang Wang
Hello David, Thanks for the KIP. For the described issue, I'm wondering if it can be resolved by tuning the CONNECTIONS_MAX_IDLE_MS_CONFIG ( connections.max.idle.ms) on the client side? Default is 9 minutes. Guozhang On Tue, May 2, 2017 at 8:22 AM, 东方甲乙 <254479...@qq.com> wrote: > Hi all, > >

[DISCUSS] KIP-148: Add a connect timeout for client

2017-05-02 Thread ????????
Hi all, Currently in our test environment, we found that after one of the broker node crash (reboot or os crash), the client may still be connecting to the crash node to send metadata request or other request, and it needs several minutes to be aware that the connection is timeout then try anot