Hi all,
In the course of reviewing the AdminClient#apiVersions API, we found out
that it was using an internal class,
org.apache.kafka.clients.NodeApiVersions. This internal class
references more internal stuff, including things in
org.apache.kafka.common.protocol. So we filed KAFKA-5214 to crea
That's a good point. It's worth mentioning that there is a KIP in
progress, KIP-133: List and Alter Configs Admin APIs, that should help
with those.
In the long term, it would be nice if we could deprecate
'allow.everyone.if.no.acl.found', along with topic auto-creation. It
should be possible to
what about the configs for: `allow.everyone.if.no.acl.found` and `
super.users`?
i understand they are an implementation detail of
`SimpleAclAuthorizer` configs,
but without these its difficult to make sense of what permissions a
`ListAclsResponse`
actually represents.
maybe something for another
On Thu, May 4, 2017, at 13:46, Magnus Edenhill wrote:
> Hey Colin,
>
> good KIP!
>
> Some comments:
>
> 1a. For operation, permission_type and resource_type: is there any reason
> for having the any and unknown enums as negative values?
> Since neither of these fields has an integer significance
Hey Colin,
good KIP!
Some comments:
1a. For operation, permission_type and resource_type: is there any reason
for having the any and unknown enums as negative values?
Since neither of these fields has an integer significance (unlike for
example offsets which use negative offsets for logical offs
Hi Jun,
Thanks for the review.
On Thu, Apr 27, 2017, at 14:21, Jun Rao wrote:
> Hi, Colin,
>
> Thanks for the KIP. Looks good overall. Just a few minor comments.
>
> 1. The controller is responsible for managing the state of topics. So, it
> makes sense for create/delete topic requests to be se
Hi, Colin,
Thanks for the KIP. Looks good overall. Just a few minor comments.
1. The controller is responsible for managing the state of topics. So, it
makes sense for create/delete topic requests to be sent to the controller.
The controller is not responsible for managing ACLs right now. So, it'
Thanks for taking a look, Ismael.
On Mon, Apr 24, 2017, at 04:36, Ismael Juma wrote:
> Thanks Colin. A few quick comments:
>
> 1. Is there a reason why AddAclsRequest must be sent to the controller
> broker? When this was discussed previously, Jun suggested that such a
> restriction may not be ne
Thanks Colin. A few quick comments:
1. Is there a reason why AddAclsRequest must be sent to the controller
broker? When this was discussed previously, Jun suggested that such a
restriction may not be necessary for this request.
2. Other protocol APIs use the Delete prefix instead of Remove. Is th
Hi all,
As part of the AdminClient work, we would like to add methods for
adding, deleting, and listing access control lists (ACLs). I wrote up a
KIP to discuss implementing requests for those operations, as well as
AdminClient APIs. Take a look at:
https://cwiki.apache.org/confluence/display/KA
10 matches
Mail list logo
