Re: [DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-04 Thread Onur Karaman
LGTM. On Sat, Feb 4, 2017 at 4:54 AM, Tom Crayford wrote: > This is great, thanks. > > On Sat, Feb 4, 2017 at 12:22 PM, Dongjin Lee wrote: > > > It also makes sense to me. Thanks for your great work, Ismael. > > > > Add to this, it seems like there should be some following work on > utilizing >

Re: [DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-04 Thread Tom Crayford
This is great, thanks. On Sat, Feb 4, 2017 at 12:22 PM, Dongjin Lee wrote: > It also makes sense to me. Thanks for your great work, Ismael. > > Add to this, it seems like there should be some following work on utilizing > some parts of the code by applying Java 8's features. > > Best, > Dongjin

Re: [DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-04 Thread Dongjin Lee
It also makes sense to me. Thanks for your great work, Ismael. Add to this, it seems like there should be some following work on utilizing some parts of the code by applying Java 8's features. Best, Dongjin On Sat, Feb 4, 2017 at 3:39 AM, Eno Thereska wrote: > Makes sense. > > Eno > > > On 3 F

Re: [DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-03 Thread Eno Thereska
Makes sense. Eno > On 3 Feb 2017, at 10:38, Ismael Juma wrote: > > Hi all, > > I have posted a KIP for dropping support for Java 7 in Kafka 0.11: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-118%3A+Drop+Support+for+Java+7+in+Kafka+0.11 > > Most people were supportive when we las

Re: [DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-03 Thread Roger Hoover
This is great. Thanks, Ismael. On Fri, Feb 3, 2017 at 7:35 AM, Grant Henke wrote: > Looks good to me. Thanks for handling the KIP. > > On Fri, Feb 3, 2017 at 8:49 AM, Damian Guy wrote: > > > Thanks Ismael. Makes sense to me. > > > > On Fri, 3 Feb 2017 at 10:39 Ismael Juma wrote: > > > > > Hi

Re: [DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-03 Thread Grant Henke
Looks good to me. Thanks for handling the KIP. On Fri, Feb 3, 2017 at 8:49 AM, Damian Guy wrote: > Thanks Ismael. Makes sense to me. > > On Fri, 3 Feb 2017 at 10:39 Ismael Juma wrote: > > > Hi all, > > > > I have posted a KIP for dropping support for Java 7 in Kafka 0.11: > > > > > > https://cw

Re: [DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-03 Thread Damian Guy
Thanks Ismael. Makes sense to me. On Fri, 3 Feb 2017 at 10:39 Ismael Juma wrote: > Hi all, > > I have posted a KIP for dropping support for Java 7 in Kafka 0.11: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-118%3A+Drop+Support+for+Java+7+in+Kafka+0.11 > > Most people were supporti

[DISCUSS] KIP-118: Drop Support for Java 7 in Kafka 0.11

2017-02-03 Thread Ismael Juma
Hi all, I have posted a KIP for dropping support for Java 7 in Kafka 0.11: https://cwiki.apache.org/confluence/display/KAFKA/KIP-118%3A+Drop+Support+for+Java+7+in+Kafka+0.11 Most people were supportive when we last discussed the topic[1], but there were a few concerns. I believe the following sh