Re: [DISCUSS] KIP-1158: Improve Connect SourceTask commit()

Thanks Chris ! I've updated the KIP and added a note in Javadocs, as you suggested. If everything looks good, should I go ahead and start a voting thread ? Thanks again, Sudesh On Tue, 8 Apr 2025 at 21:47, Chris Egerton wrote: > Consistent behavior sounds good to me! We should probably add a no

Re: [DISCUSS] KIP-1158: Improve Connect SourceTask commit()

Hello Chris ! Thanks for the quick review ! Good point, task.commit() (existing and proposed) should fail the task on exception. Currently, if a connector implements task.commit()

Re: [DISCUSS] KIP-1158: Improve Connect SourceTask commit()

Consistent behavior sounds good to me! We should probably add a note on that to the Javadocs but I don't consider this a blocker. Thanks again, no further feedback from me. On Tue, Apr 8, 2025, 12:12 Sudesh Wasnik wrote: > Hello Chris ! Thanks for the quick review ! > > Good point, task.commit(

Re: [DISCUSS] KIP-1158: Improve Connect SourceTask commit()

Hi Sudesh, Thanks for the KIP. The existing commit method is... not great. I think the word "futile" you chose in the KIP is putting it lightly. The new interface looks clean, implementation seems extremely straightforward, and everything's backwards compatible. The only comment I'll leave is th

[DISCUSS] KIP-1158: Improve Connect SourceTask commit()

Hi all, I would like to discuss KIP-1158. This KIP introduces a new "commit()" method in KafkaConnect SourceTask interface, primarily for use-cases where SourceConnectors need to track "source-offset" commits. Thanks in advance for reviewing ! KIP : https://cwiki.apache.org/confluence/pages/viewp