Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread Chia-Ping Tsai
hi TengYao please sync the update to the vote thread. thanks Best, Chia-Ping TengYao Chi 於 2025年5月12日 週一 上午12:07寫道: > Hi Chia-Ping > Nice catch! > I have updated the KIP. > > Best, > TengYao > > Chia-Ping Tsai 於 2025年5月11日 週日 下午4:34寫道: > > > hi Teng > > > > Sorry for raising issue on the acce

Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread TengYao Chi
Hi Chia-Ping Nice catch! I have updated the KIP. Best, TengYao Chia-Ping Tsai 於 2025年5月11日 週日 下午4:34寫道: > hi Teng > > Sorry for raising issue on the accepted KIP. > > In 5.0 the log cleaner should be always enabled and so the config > log.cleaner.threads should NOT accept min value of zero, rig

Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread Chia-Ping Tsai
hi Teng Sorry for raising issue on the accepted KIP. In 5.0 the log cleaner should be always enabled and so the config log.cleaner.threads should NOT accept min value of zero, right? Hence, could you please add the behavior changes “the min value should be 1” to this KIP? Best, Chia-Ping On

Re: [DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-05-11 Thread Chia-Ping Tsai
hi Teng Sorry for raising issue on the accepted KIP. In 5.0 the log cleaner should be always enabled and so the config log.cleaner.threads should NOT accept min value of zero, right? Hence, could you please add the behavior changes “the min value should be 1” to this KIP? Best, Chia-Ping On

[DISCUSS] KIP-1148: Remove log.cleaner.enable configuration

2025-03-24 Thread TengYao Chi
Hello everyone, I want to start a discussion thread on KIP-1148 , which proposes removing the `log.cleaner.enable` configuration. Please take a look and let me know what you think. I would appreciate any suggestions and feedback. Best regards, TengYao