Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

recated and will be removed in a future major Kafka > version (5.0)." > > I agree with Chia-Ping that getting this into AK 4.0 would be great. > > Thanks, > Andrew > > From: Apoorv Mittal > Sent: 13 December 2024 00:28 > To:

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

l Sent: 13 December 2024 00:28 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics Thanks Chia. I have started the voting thread: https://lists.apache.org/thread/fvn9r9lw55lyf971k6z4qnpnmq9tmm50 Regards, Apoorv Mittal On Thu, Dec 12, 2024 at 11:

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Thanks Chia. I have started the voting thread: https://lists.apache.org/thread/fvn9r9lw55lyf971k6z4qnpnmq9tmm50 Regards, Apoorv Mittal On Thu, Dec 12, 2024 at 11:46 PM Chia-Ping Tsai wrote: > hi Apoorv > > Thank you for the update. It looks good to me. Perhaps we can start the > vote. > > Inc

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

hi Apoorv Thank you for the update. It looks good to me. Perhaps we can start the vote. Including this in version *4.0* would be great. :) Best, Chia-Ping Apoorv Mittal 於 2024年12月13日 週五 上午4:16寫道： > Hi Jun and Chia, > Thanks for the feedback and review. I have updated the KIP with details. > >

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Hi Jun and Chia, Thanks for the feedback and review. I have updated the KIP with details. There will be duplicate metrics as below, after the KIP, only for topics with period (.). [image: Screenshot 2024-12-12 at 15.44.37.png] Regards, Apoorv Mittal On Tue, Dec 10, 2024 at 3:46 AM Chia-Ping Ts

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

hi Apoorv, Let's use the following example to explain my point. in 4.0 *Topic Name: topic.a.b* - *Deprecated Metric Added:* A deprecated metric with the tag topic_a_b has been added. - *New Metric Added:* A new metric with the tag topic.a.b has been introduced. Users should monitor t

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Hi, Apoorv, I thought Chia's suggestion is to emit the metric under both the topic name with and without dot replacement. Thanks, Jun On Wed, Nov 27, 2024 at 3:06 PM Apoorv Mittal wrote: > Thanks Jun and Chia for review and feedback. > > Initially I thought this might be a breaking change for

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Thanks Jun and Chia for review and feedback. Initially I thought this might be a breaking change for someone who has written a transformation over topic name and expects them to be "_" replaced, if dot exists. But the fix is actually a correction of the topic name itself hence was wondering if we

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Hi, Chia-Ping, We could deprecate those metrics too. Then, we probably want to do a formal KIP on this. Thanks, Jun On Tue, Nov 19, 2024 at 3:11 AM Chia-Ping Tsai wrote: > hi Apoorv, > > Should we follow the deprecation cycle in this KIP? I mean, we should keep > both metrics for now and add

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

hi Apoorv, Should we follow the deprecation cycle in this KIP? I mean, we should keep both metrics for now and add a description to inform users that the metrics are deprecated. hi Jun The incorrect topic metrics have existed for a while, so I believe it would be better to follow a deprecation c

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Hi, Apoorv, We did the dot replacement in Yammer metric scope to help with the naming schema used in Graphite and the java consumer code just copied it. Since this is an issue very specific to Graphite, it's better not to change the name directly in Kafka metric. If needed, a Graphite specific rep

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Moreover on a second thought, as this should be a correction in emitted topic names then we should not require a KIP per say but just fix it as part of jira itself. Please let me know your thoughts. Regards, Apoorv Mittal On Fri, Nov 15, 2024 at 10:16 PM Apoorv Mittal wrote: > Hi All, > I hav

Re: [DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Hi All, I have added the Context section in the KIP as per the discussion on the jira . Please let me know if there is any feedback or I shall directly start the voting thread. Regards, Apoorv Mittal On Tue, Nov 12, 2024 at 12:49 PM Apoorv Mitta

[DISCUSS] KIP-1109: Unifying Kafka Consumer Topic Metrics

Hi All, I would like to start a discussion on KIP-1109: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1109%3A+Unifying+Kafka+Consumer+Topic+Metrics This KIP streamlines topic and topic-partition metrics for Kafka Consumer, emitting the user defined topic name (as like kafka-producer). Reg