Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2025-03-31 Thread Dániel Urbán
; > > > > Thanks, > > > > > > Daniel > > > > > > > > > > > > Vidor Kanalas ezt írta (időpont: 2024. > > > nov. > > > > > > 15., P, 10:36): > > > > > > > > > > > >> Hi Daniel, &g

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2025-03-28 Thread Mickael Maison
bout. Suppose we have > > a > > > > >> topic on a prod cluster A that is replicated to a backup cluster B. > > > > There > > > > >> is a CG that is working through the messages on the backup cluster, > > > > before > > > > &

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-26 Thread Viktor Somogyi-Vass
t is working through the messages on the backup cluster, > > > before > > > >> it’s promoted to the prod cluster. In this case that CG does not > exist > > > on > > > >> cluster A, and it won’t be checkpointed (obviously), but it’s not >

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-25 Thread Dániel Urbán
the above setup is an actual real-world use case, > but > > >> if it is, we need to make sure that CGs can get reverse checkpointed > > even > > >> if they initially don’t exist on the cluster. (it’s not a traditional > > >> failover + failback scenario). Th

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-22 Thread Viktor Somogyi-Vass
if it will be reverse checkpointed. > >> I’m not certain if the above setup is an actual real-world use case, but > >> if it is, we need to make sure that CGs can get reverse checkpointed > even > >> if they initially don’t exist on the cluster. (it’s not a traditional &g

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-20 Thread Dániel Urbán
ing that a reverse >> checkpointing group filter could be useful, but I agree that the same can >> be achieved with the existing filter. >> >> Best, >> Vidor >> >> >> From: Dániel Urbán >> Date: Friday, 15 November 2024 at 09:35 >> To: de

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-15 Thread Dániel Urbán
ree that the same can > be achieved with the existing filter. > > Best, > Vidor > > > From: Dániel Urbán > Date: Friday, 15 November 2024 at 09:35 > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker > Hi Viktor, > >

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-15 Thread Vidor Kanalas
agree that the same can be achieved with the existing filter. Best, Vidor From: Dániel Urbán Date: Friday, 15 November 2024 at 09:35 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker Hi Viktor, SVV3. In the current proposal, if the TopicFilter is

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-15 Thread Dániel Urbán
Hi Viktor, SVV3. In the current proposal, if the TopicFilter is not provided, it enables a different logic for reverse checkpointing - the task relies on the ReplicationPolicy to detect if a topic in the source cluster is a replica originating from the target cluster, e.g. in the A->B flow, the to

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-14 Thread Viktor Somogyi-Vass
Hi Daniel, SVV3. Kind of an implementation detail. So I think using TopicFilter is good, however I was wondering if we should provide a default implementation instead of null? We have to implement the pass-through behavior anyways, and it makes sense to me to do it in a filter. SVV4. Also, an alte

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-07 Thread Dániel Urbán
Gentle bump - any comments are welcome. This could fill an important gap in MM2, and would be nice to fix. TIA Daniel Dániel Urbán ezt írta (időpont: 2024. nov. 4., H, 11:00): > Hi Vidor, > > Thank you for your comments! > > 1. I think the optimization sounds nice, but would not work well with >

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-11-04 Thread Dániel Urbán
Hi Vidor, Thank you for your comments! 1. I think the optimization sounds nice, but would not work well with TopicFilter implementations which can be dynamically updated in the background (without touching the Connector configuration). If we actually dropped the offset sync records for a topic wh

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-30 Thread Vidor Kanalas
Hi Daniel, This would indeed greatly reduce the duplicate processing on failbacks. Few questions: 1. Since having a second offset-sync store can be memory intensive, would it make sense to filter the topics in it based on the reverseCheckpointingTopicFilter? 2. Would it make sens

[DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-30 Thread Vidor Kanalas
Hi Daniel, This would indeed greatly reduce the duplicate processing on failbacks. Few questions: 1. Adding another offset sync store might be memory intensive. Would it make sense (if possible) to filter the topics in it based on the reverseCheckpointingTopicFilter? 2. Would it make sen

RE: Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-30 Thread Vidor Kanalas
Hi Daniel, This would indeed greatly reduce the duplicate processing on failbacks. Few questions: Adding another offset sync store might be memory intensive. Would it make sense (if possible) to filter the topics in it based on the reverseCheckpointingTopicFilter? Would it make sense to add a

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-28 Thread Vidor Kanalas
Hi Daniel, This would indeed greatly reduce the duplicate processing on failbacks. Few questions: 1. Adding another offset sync store might be memory intensive. Would it make sense (if possible) to filter the topics in it based on the reverseCheckpointingTopicFilter? 2. Would it make sen

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-28 Thread Dániel Urbán
Hi Viktor, SVV1. Not easy to provide a number, but yes, it does scale with the number of replicated topic partitions. Enabling this feature will add the overhead of an extra consumer, and allocates memory for an offset-sync index for each partition. The index is limited to 64 entries. I could give

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-28 Thread Viktor Somogyi-Vass
Hi Daniel, SVV1. Fair points about the performance impact. The next question is that can we quantify it somehow, ie. does it scale with the number of topics to reverse checkpoints, the offsets emitted, etc.? I'll do one more pass on the KIP in the following days but I wanted to reply to you with

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-25 Thread Dániel Urbán
Hi, One more update. As I was working on the PR, I realized that the only way to support IdentityReplicationPolicy is to add an extra topic filter to the checkpointing. I updated the KIP accordingly. I also opened a draft PR to demonstrate the proposed changes: https://github.com/apache/kafka/pull

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-24 Thread Dániel Urbán
Hi all, Just a bump/minor update here: As I've started working on a POC of the proposed solution, I've realised that the hard requirement related to the ReplicationPolicy implementation can be eliminated, updated the KIP accordingly. Daniel Dániel Urbán ezt írta (időpont: 2024. okt. 21., H, 16:18

Re: [DISCUSS] KIP-1098: Reverse Checkpointing in MirrorMaker

2024-10-21 Thread Dániel Urbán
Hi Mickael, Good point, I renamed the KIP and this thread: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1098%3A+Reverse+Checkpointing+in+MirrorMaker Thank you, Daniel Mickael Maison ezt írta (időpont: 2024. okt. 21., H, 15:22): > Hi Daniel, > > I've not had time to take a close look at