Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks Lianet, Updated KIP to include LM5 On Wed, Nov 13, 2024 at 9:14 PM Lianet M. wrote: > Hello, thanks for the updates. Just a minor comment left > > LM5. Should we add the change to the AuthorizationException parent to the > public interfaces section? Same for the InvalidMetadataException.

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Hello, thanks for the updates. Just a minor comment left LM5. Should we add the change to the AuthorizationException parent to the public interfaces section? Same for the InvalidMetadataException. Thanks! Lianet On Tue, Nov 12, 2024 at 1:52 PM Kaushik Raina wrote: > Thanks Lianet for review

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks Lianet for review LM1 & LM2: We will extend parent classes only to maintain the hierarchy For TopicAuthorizationException and GroupAuthorizationException, we will extend parent class AuthorizationException. So new hierarchy will be "AuthorizationException < InvalidConfigurationException <

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Hey Lianet, Thanks for raising these issues. I think that the parent classes (AuthorizationException and InvalidMetadataException) should extend our new groupings (InvalidConfig and RefreshRetriable). We can confirm this works as expected. I'm not as familiar with CommitFailedException, but we can

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Hello, sorry for the late reply, took another pass after the latest updates. Most of the proposed groupings and handling seem good and very helpful indeed from the producer perspective. I just have some more comments related to the changes in the exception hierarchy, that are not scoped to the prod

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks Artem for valuable comments I have incorporated them into the updated KIP. On Sat, Oct 19, 2024 at 3:31 AM Artem Livshits wrote: > Hi Kaushik, > > Thank you for the KIP! I think it'll make writing transactional > application easier and less error prone. I have a couple comments: > > A

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks Lianet for valuable comments 107) & 108) We have updated group exception names, which will prevent error in current applications which are handing producer/consumer exceptions ``` ProducerRetriableTransactionException -> RetriableException ProducerRefreshRetriableTransactionException -> Re

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Hi Kaushik, Thank you for the KIP! I think it'll make writing transactional application easier and less error prone. I have a couple comments: AL1. The keep proposes changing the semantics of UnknownProducerIdException. Currently, this error is never returned by the broker so we cannot valida

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Hello, thanks for the KIP! After going through the KIP and discussion here are some initial comments. 107 - I understand we’re proposing a new ProducerRetriableTransactionException, and changing existing exceptions to inherit from it (the ones on the table below it). The existing exceptions inhe

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks for review Matthias 100/101 - Updated in KIP 104 - Added explicitly `For Producer-Retriable errors, the producer handles retries internally, keeping the failure details hidden from the application. Conversely, other types of exceptions will be surfaced to the application code for handling.

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Hey Matthias, 102/103) Sorry for the confusion on the TransactionAbortableException. Here is the error -- we have an error name and an exception name -- this is the same error mentioned in KIP-890. It is also implemented so that new clients throw this error when transaction verification fails. htt

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks for updating the KIP. It's much clearer now what you propose. I have a bunch of question about the proposal: (100) nit (typo / missing word?): We would new error types (101) `TransactionAbortableException`, `ProducerFencedException`, and `UnknownProducerIdException` are listed tw

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Additionally, - We will be depreciating KIP-691 in favour of KIP-1050. On Fri, Jun 21, 2024 at 12:20 PM Kaushik Raina wrote: > Thanks Matthias for feedback > - We have updates KIP and grouped exceptions > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1050%3A+Consistent+error+handling+fo

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks Matthias for feedback - We have updates KIP and grouped exceptions https://cwiki.apache.org/confluence/display/KAFKA/KIP-1050%3A+Consistent+error+handling+for+Transactions#KIP1050:ConsistenterrorhandlingforTransactions-ExceptionTable - Regarding compatibility, all changes in KIP are expect

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thanks for this KIP. Great to see it. I would assume it will make KIP-691 unnecessary? I don't think I fully understand the proposal yet. It's clear, that you propose to add new sub-classed to group existing exceptions. But it's not clear to me, which of the existing exceptions (which implemen

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Thank you Andrew for feedback 1. We are suggesting to only update subclasses of o.a.k.common.errors.ApiException, which are used in transactions. All such subclasses are mentioned in Exception table

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

Hi Kaushik, Thanks for the KIP. This is definitely an area that needs clearing up so it’s good to see it. A few initial questions. 1. If I understand correctly, you are proposing to change the superclass of all subclasses of o.a.k.common.errors.ApiException which can be thrown by the producer o

[DISCUSS] KIP-1050: Consistent error handling for Transactions

Hi everyone, I would like to start a discussion thread for KIP-1050: Consistent error handling for Transactions https://cwiki.apache.org/confluence/display/KAFKA/KIP-1050%3A+Consistent+error+handling+for+Transactions Thanks Kaushik Raina