Re: [DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-06-10 Thread Matthias J. Sax
Thanks for updating the KIP. Overall LGTM. However, "rejected alternatives" still says: add a new configuration log.summary.interval.ms to control the output interval of summary log This seems not to be rejected, but what the KIP actually proposes and should be removed? I think you can s

Re: [DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-06-05 Thread jiang dou
@Matthias Alternatives also add `log.summary.interval.ms` config and add other config `log.summary.interval.switch ` use control whether the log summary function is enabled。 In project practice, some developers like to display whether the relevant functions are e

Re: [DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-06-05 Thread jiang dou
@Sophie I'm sorry I didn't see this email. I want add configuration in StreamConfig and define default value,I have updated KIP Sophie Blee-Goldman 于2024年5月29日周三 15:56写道: > Sure, as I said I'm supportive of this KIP. Just wanted to mention how the > issue could be mitigated in the meantime sinc

Re: [DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-06-04 Thread Matthias J. Sax
Jiang, Thanks for the KIP. I think it make sense. I agree with Sophie that the KIP writeup should be improved a little bit, with regard to public API (ie, config) which are changed. The only other idea I had to avoid this issue would be some internal change: we would introduce a new logger c

Re: [DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-05-29 Thread Sophie Blee-Goldman
Sure, as I said I'm supportive of this KIP. Just wanted to mention how the issue could be mitigated in the meantime since the description made it sound like you were suffering from excessive logs right now. Apologies if I misinterpreted that. I do think it would be nice to have a general setting f

Re: [DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-05-23 Thread jiang dou
Thank you for your reply, I do not recommend agreeing set log level is WARN, because INFO level logs should be useful Sophie Blee-Goldman 于2024年5月23日周四 04:30写道: > Thanks for the KIP! > > I'm not against adding this as a config for this per se, but if this is > causing you trouble right now you

Re: [DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-05-22 Thread Sophie Blee-Goldman
Thanks for the KIP! I'm not against adding this as a config for this per se, but if this is causing you trouble right now you should be able to disable it via log4j configuration so you don't need to wait for a fix in Kafka Streams itself. Putting something like this in your log4j will shut off th

[DISCUSS] KIP-1049: Add config log.summary.interval.ms to Kafka Streams

2024-05-22 Thread jiang dou
Hi I would like to propose a change in the kafka-stream summary log。 Now the summary of stream-tread is record every two minutes, and not support close or update intervals. When the kafka is running, this is absolutely unnecessary and even harmful since it fills the logs and thus storage spac