Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

The KIP has been updated to include the changes to the ConnectRestExtensionContext. On Tue, Jul 9, 2024 at 7:16 PM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > Thanks, I missed that, I can update the KIP tomorrow to include that. > > Chris > > On Tue, Jul 9, 2024 at 6:15 PM Chr

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Thanks, I missed that, I can update the KIP tomorrow to include that. Chris On Tue, Jul 9, 2024 at 6:15 PM Chris Egerton wrote: > Hi Chris, > > Thanks for the updates and the additional context. I have one last > nit after doing another readthrough: in the public interfaces section it > states

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi Chris, Thanks for the updates and the additional context. I have one last nit after doing another readthrough: in the public interfaces section it states that "There shouldn't be changes to the main client API as the API doesn't use jakarta". This is almost true, but like Greg has mentioned pre

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi Chris, I can make those changes. For number 2 that was a holdover back when we were discussing 11 vs 12 and whether or not JDK 17 would be used, but we are going with 12 since 11 is deprecated so I will fix that. On Tue, Jul 9, 2024 at 2:54 PM Chris Egerton wrote: > Hi Chris, > > Thanks for

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi Chris, Thanks for the KIP! It's a bit of a drastic change to rip the bandaid off like this and require users running Connect to upgrade to JDK 17, but I think it's the best out of the options that are available to us. Two small nits on the KIP: 1. It'd be nice to link to KIP-1013 in the motiva

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi Greg, I will make a couple quick tweaks and open a vote. I think we should target JDK 17, JavaEE 10 and Jetty 12 because Jetty 11 is now EOL. Chris On Mon, Jul 8, 2024 at 2:13 PM Greg Harris wrote: > Hi Chris, > > Please open a vote thread for this. > > Thanks, > Greg > > On Tue, May 14, 20

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi Chris, Please open a vote thread for this. Thanks, Greg On Tue, May 14, 2024 at 9:07 AM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > I just wanted to bump this and see if anyone had more feedback before > trying to call a vote for this for 4.0? > > Chris > > On Mon, Apr 1,

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

I just wanted to bump this and see if anyone had more feedback before trying to call a vote for this for 4.0? Chris On Mon, Apr 1, 2024 at 3:41 PM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > Greg, > > 1. Ok sounds good we can target JDK 17 in this KIP if we decide to do that.

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Greg, 1. Ok sounds good we can target JDK 17 in this KIP if we decide to do that. 2. For the EE version, I don't think it really matters since we won't be using any new features that I am aware of. It's just something I noticed that we will need to pick because Jetty 12 supports multiple versions

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hey Chris, Thanks for your questions! 1. KIPs are generally immutable once they've been voted on. In this case, I think it's better that this KIP include the bump to Java 17 just for Connect and MirrorMaker 2, and should include that in the KIP title. 2. I'm not familiar with the difference, can

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi Greg, Thanks for the detailed analysis on the connect framework. It sounds like hopefully we can go ahead and require JDK 17+ and bump that dependency for the ConnectRestExtensionContext. I agree we can leave it open and hear what others think as well about the requirement, if everyone ends up

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hey all, I looked into how Debezium handled the javax->jakarta changeover for Quarkus, and found this release note: https://debezium.io/blog/2023/04/20/debezium-2-2-final-released/#new-quarkus-3 It appears that Debezium 2.1 required Quarkus < 3.0, and Debezium 2.2 required Quarkus >= 3.0. The upgr

Re: [DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi Chris, Thank you so much for opening this KIP, and making sure Kafka keeps up with the rest of the Java ecosystem! I took a look around at some Open Source connector implementations, and checked their Java version support: * The Aiven connect plugins (http, bigquery, jdbc, elasticsearch, opens

[DISCUSS] KIP-1032: Upgrade to Jakarta and JavaEE 9 in Kafka 4.0

Hi, I'm proposing a KIP for Kafka 4.0 to upgrade to to Jakarta and JavaEE 9 APIs. This will also upgrade dependencies like Jetty and move away from the depcrated javax namespace to be in line with other libraries and frameworks. There was some initial