Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-15 Thread Chris Egerton
gt; > > people > > > > > > gauge how to respond to non-200 responses, and we can try to > improve > > > > > > wording and granularity over time based on user feedback. You and > > > other > > > > > > users may develop automated responses

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-14 Thread Edoardo Comar
gt; > > > for expansion of the response format in the future, but would like to > > > > hold > > > > > off on that for now. > > > > > > > > > > [1] - https://issues.apache.org/jira/browse/KAFKA-15563 > > > > &g

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-14 Thread Viktor Somogyi-Vass
ave a couple of questions / suggestions: > > > > > > > > 1. What are you planning on documenting as guidance for using this > new > > > > endpoint? My guess would be that if Connect doesn’t return a status > of > > > 200 > > > > after some

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-14 Thread Chris Egerton
> > > On Tue, Jun 11, 2024 at 3:37 AM Adrian Preston > > > > wrote: > > > > > > > > > Hi Chris, > > > > > > > > > > Good KIP – I think it will be very helpful in alerting and > automating > > > the > >

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-11 Thread Chris Egerton
us of > > 200 > > > after some period I would either page someone, or restart the process? > > But > > > I’m missing the nuance of distinguishing between readiness and > liveness, > > is > > > this for maintaining overall availability when rolling out

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-11 Thread Viktor Somogyi-Vass
ould you consider providing a way to discover details about exactly > > which condition (or conditions) is/are failing? Perhaps by providing a > > richer JSON response? Something like this would help us adopt the health > > check, as we could start by paging someone for all fail

RE: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-11 Thread Adrian Preston
robust implementation before considering further enhancements. Cheers, - Adrian. From: Chris Egerton Date: Tuesday, 11 June 2024 at 15:34 To: dev@kafka.apache.org Subject: [EXTERNAL] Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect Hi Adrian, Thanks for your comments/questions

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-11 Thread Chris Egerton
on. > > Regards, > - Adrian > > > From: Chris Egerton > Date: Monday, 10 June 2024 at 15:26 > To: dev@kafka.apache.org > Subject: [EXTERNAL] Re: [DISCUSS] KIP-1017: A health check endpoint for > Kafka Connect > Hi all, > > Thanks for the positive feedback! > >

RE: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-11 Thread Adrian Preston
) transition more of the conditions over to being handled by automation. Regards, - Adrian From: Chris Egerton Date: Monday, 10 June 2024 at 15:26 To: dev@kafka.apache.org Subject: [EXTERNAL] Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect Hi all, Thanks for the positive feedback

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-10 Thread Chris Egerton
Hi all, Thanks for the positive feedback! I've made one small addition to the KIP since there's been a change to our REST timeout error messages that's worth incorporating here. Quoting the added section directly: > Note that the HTTP status codes and "status" fields in the JSON response will ma

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-07 Thread Andrew Schofield
Hi Chris, This KIP looks good to me. I particularly like the explanation of how the result will specifically check the worker health in ways that have previously caused trouble. Thanks, Andrew > On 7 Jun 2024, at 16:18, Mickael Maison wrote: > > Hi Chris, > > Happy Friday! The KIP looks good to

Re: [DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-06-07 Thread Mickael Maison
Hi Chris, Happy Friday! The KIP looks good to me. +1 Thanks, Mickael On Fri, Jan 26, 2024 at 8:41 PM Chris Egerton wrote: > > Hi all, > > Happy Friday! I'd like to kick off discussion for KIP-1017, which (as the > title suggests) proposes adding a health check endpoint for Kafka Connect: > http

[DISCUSS] KIP-1017: A health check endpoint for Kafka Connect

2024-01-26 Thread Chris Egerton
Hi all, Happy Friday! I'd like to kick off discussion for KIP-1017, which (as the title suggests) proposes adding a health check endpoint for Kafka Connect: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1017%3A+Health+check+endpoint+for+Kafka+Connect This is one of the longest-standing is