Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hi All, I like your idea, Victor, and I am ready to drop this KIP (or modify) in this form and focus my attention on the suggested long term solution. > deprecate ReplicationPolicy as an interface and just replace it with > a fully configurable DefaultReplicationPolicy class where all topic names

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hi all, Regarding Omnia's last point: I also second that with a reasonable default we won't really complicate average users' problems while setting a config is simpler than having to provide a jar to override the replication policy. I have also mulled over what if we created a separate replication

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hi All, *Viktor * I was wrong sorry, Chris is right we have the per replication flow configuration for free. *Chris, regarding your comments.* *>IMO we don't need the "default." prefix* Sure I can do that, my intention with that was to make it clear for the users, that this property is not compat

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

I noticed you have something addressed in the rejected alternatives in your KIP regarding KIP-690, however, as the KIP is implementing one of the previous rejected alternatives for KIP-690 I think it would be nice to update the motivation section in the new KIP with some clarification for why wh

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hi Thanks for the KIP. I don’t know if you had a look before into the rejection alternatives in KIP-690 https://cwiki.apache.org/confluence/display/KAFKA/KIP-690%3A+Add+additional+configuration+to+control+MirrorMaker+2+internal+topics+naming+convention#KIP690:AddadditionalconfigurationtocontrolM

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hi Berci, Thanks for the KIP! IMO we don't need the "default." prefix for the new property, and it deviates a bit from the precedent set by properties like "replication.policy.internal.topic.separator.enabled". I think we can just call it "replication.policy.heartbeats.topic", or if we really wan

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hi Viktor, Let me address your points one by one. 1. The current implementation does not support the source->target pair based configuration, it is global. 2. Yes, I introduced that property both in the client and in the connectors 3. This is a great idea, I am going to do that, an

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hi Bertalan, Thanks for creating this KIP. A couple of observations/questions: 1. If I have multiple source->target pairs, can I set this property per cluster by prefixing with "source->target" as many other configs or is it global? 2. The replication policy must be set in MirrorClient as well. Is

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Makes sense to me, +1. On Tue, Jan 16, 2024 at 5:04 PM Kondrát Bertalan wrote: > Hey Team, > > I would like to start a discussion thread about the *KIP-1016 Make MM2 > heartbeats topic name configurable > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1016+Make+MM2+heartbeats+topic+na

[DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

Hey Team, I would like to start a discussion thread about the *KIP-1016 Make MM2 heartbeats topic name configurable * . This KIP aims to make the default heartbeat topic name (`heartbeats`) in