Re: [DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-03 Thread Pranav Maniar
Thanks Jason ! I will create KIP for the same. On Wed, Aug 2, 2017 at 11:12 PM, Jason Gustafson wrote: > Hey Pranav, > > Thanks for raising this. I already commented on the JIRA, but I'll > reiterate my thoughts here. The "log cleaner" naming may not be ideal, but > it is not incorrect and some

Re: [DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-02 Thread Jason Gustafson
Hey Pranav, Thanks for raising this. I already commented on the JIRA, but I'll reiterate my thoughts here. The "log cleaner" naming may not be ideal, but it is not incorrect and some of the terminology used elsewhere makes more sense given this name (e.g. cleanable ratio, dirty offset). I personal

[DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-01 Thread Pranav Maniar
Hi All, I am planning to take up [KAFKA-1944 ] : Rename LogCleaner to LogCompactor. Renaming will cover LogCleander, LogCleanerManager, related Testcases and all method/variable/documentations inside it. It also requires configuration name change