As of Present (Corrected and Updated):
Committers:
- Gwen, John, Matthias: (No Specific Preference)
- Sophie: 2.
Non-Committers:
- Brandon: 2.
- Bruno: 2 and 3.
- Dongjin: 2 and 3.
It seems like option 2 (i.e., the second least changing, three group scheme
of kafka, java, etc.) is the most fav
Hi,
Personally I don't care about which order we choose, but having one
seems reasonable.
My main ask is, can we document clearly, how tools like IntelliJ and
Eclipse need to be configured such that they obey the defined rules? It
would be very annoying of it would be required to disable "auto im
Hi Dongjin,
Thanks for bringing this up. I’m in favor of adding a check style rule.
Thanks for testing out the alternatives. As long as we aren’t adding wildcard
imports and as long as it’s easy to configure IDEs with our chosen rules, I
have no preference. I assume these hold for your proposa
Bruno is committer-like :)
I generally prefer option 2, but would definitely be happy with any of them.
I'm pretty sure I'm personally responsible for some of the wacky import
ordering way back when, before I set my IDE configuration straight. It took
me a while to notice because we never had a c
Hi Dongjin,
Thank you that you put me into the committer section, but I am actually
not a committer.
Best,
Bruno
On 23.10.20 07:46, Dongjin Lee wrote:
As of Present:
Committers:
- Bruno: 2 and 3.
- Gwen: (No Specific Preference)
Non-Committers:
- Brandon: 2.
- Dongjin: 2 and 3.
Let's h
As of Present:
Committers:
- Bruno: 2 and 3.
- Gwen: (No Specific Preference)
Non-Committers:
- Brandon: 2.
- Dongjin: 2 and 3.
Let's hold on for 2 or 3 committers.
Best,
Dongjin
On Fri, Oct 23, 2020 at 10:09 AM Gwen Shapira wrote:
> I don't have any specific preference on the style. But I
I don't have any specific preference on the style. But I am glad you
are bringing it up. Every other project I worked on had a specific
import style, and the random import changes in PRs are pretty
annoying.
On Wed, Oct 14, 2020 at 10:36 PM Dongjin Lee wrote:
>
> Hello. I hope to open a discussio
I like option 2.
Brandon Brown
> On Oct 15, 2020, at 1:36 AM, Dongjin Lee wrote:
>
> Hello. I hope to open a discussion about the import order in Java code.
>
> As Nikolay stated recently[^1], Kafka uses a relatively strict code style
> for Java code. However, it misses any rule on import or
Hi Dongjin,
Thank you for bringing this up.
I like options 2 and 3.
Best,
Bruno
On 15.10.20 07:36, Dongjin Lee wrote:
Hello. I hope to open a discussion about the import order in Java code.
As Nikolay stated recently[^1], Kafka uses a relatively strict code style
for Java code. However, it m
Hello. I hope to open a discussion about the import order in Java code.
As Nikolay stated recently[^1], Kafka uses a relatively strict code style
for Java code. However, it misses any rule on import order. For this
reason, the code formatting settings of every local dev environment are
different f
10 matches
Mail list logo
